Updated root to tip of branch v6-14-00-patches #4277

mrodozov · 2018-08-21T15:00:54Z

Get latest commits (recent PR root-project/root#2488 now merged)

cmsbuild · 2018-08-21T15:01:15Z

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_3_X/rootnext.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

mrodozov · 2018-08-21T15:02:19Z

please test

cmsbuild · 2018-08-21T15:02:33Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29950/console

mrodozov · 2018-08-21T15:04:10Z

abort

cmsbuild · 2018-08-21T15:04:33Z

Jenkins tests are aborted.

cmsbuild · 2018-08-21T15:05:10Z

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#22594
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29951/console

mrodozov · 2018-08-22T12:27:02Z

please test

cmsbuild · 2018-08-22T12:27:17Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29964/console

mrodozov · 2018-08-22T12:27:38Z

test on it's own to see if it would break as master (still one unit test and addon test failing)

davidlange6 · 2018-08-24T08:04:35Z

please test

cmsbuild · 2018-08-24T08:04:50Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30031/console

cmsbuild · 2018-08-24T19:36:07Z

-1

Tested at: 37a12df

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4277/30031/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests AddOn

Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Fri Aug 24 21:25:35 2018-date Fri Aug 24 20:58:52 2018 s - exit: 35584
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Fri Aug 24 21:21:35 2018-date Fri Aug 24 20:59:14 2018 s - exit: 35584
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Fri Aug 24 21:23:47 2018-date Fri Aug 24 20:59:18 2018 s - exit: 35584
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_MC.root --fileout file:RelVal_Raw_Fake2_MC_HLT_RECO.root : FAILED - time: date Fri Aug 24 21:23:34 2018-date Fri Aug 24 20:59:19 2018 s - exit: 35584
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Fri Aug 24 21:20:02 2018-date Fri Aug 24 20:59:28 2018 s - exit: 35584
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Fri Aug 24 21:24:38 2018-date Fri Aug 24 20:59:35 2018 s - exit: 35584

cmsbuild · 2018-08-24T19:36:09Z

Comparison job queued.

cmsbuild · 2018-08-25T01:20:44Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4277/30031/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2987459
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2987267
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 129 log files, 14 edm output root files, 31 DQM output files

slava77 · 2018-08-27T13:05:26Z

@mrodozov
are the tests here now good enough to be merged?
I'm asking in relation to cms-sw/cmssw#22594 (comment)

mrodozov · 2018-08-27T15:00:48Z

Compared with what we merged on root master branch is acceptable. So I'll merge it

mrodozov · 2018-08-27T15:00:57Z

+externals

cmsbuild · 2018-08-27T15:02:59Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_3_X/rootnext IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

slava77 · 2018-08-29T21:41:11Z

IIUC, this PR is now included in CMSSW_10_3_ROOT614_X_2018-08-28-2300, including the fix from root-project/root#2488

I still have a similar problem to the one that was present in earlier tests in July in cms-sw/cmssw#22594 (comment)

To reproduce

setup the release
in root -l -b do the following:

FWLiteEnabler::enable();
en = new TChain("Events");
en->Add("root://cms-xrd-global.cern.ch//store/relval/CMSSW_9_4_5_cand1/RelValTTbar_13/MINIAODSIM/94X_mc2017_realistic_v14_PU_RelVal_rmaod-v1/10000/84A84D5B-9E2E-E811-B103-0CC47A7C35F4.root");
#a local copy is available on cmsdev14:/build/slava77/RawReference/RelValTTbar_13/CMSSW_9_4_5_cand1-94X_mc2017_realistic_v14_PU_RelVal_rmaod-v1/MINIAODSIM/84A84D5B-9E2E-E811-B103-0CC47A7C35F4.root
en->Scan("patJets_slimmedJets__PAT.obj.pt()");

The above ends with *** Break *** segmentation violation
with stack trace:

#11 0x00007f6d941ed147 in void std::_Destroy_aux<false>::__destroy<edm::PtrVector<reco::Candidate>*>(edm::PtrVector<reco::Candidate>*, edm::PtrVector<reco::Candidate>*) () from /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_ROOT614_X_2018-08-28-2300/lib/slc6_amd64_gcc700/libDataFormatsCandidate.so
#12 0x00007f6d941efe8d in ROOT::Detail::TCollectionProxyInfo::Pushback<std::vector<edm::PtrVector<reco::Candidate>, std::allocator<edm::PtrVector<reco::Candidate> > > >::resize(void*, unsigned long) () from /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_ROOT614_X_2018-08-28-2300/lib/slc6_amd64_gcc700/libDataFormatsCandidate.so
#13 0x00007f6daa0a2c7c in TGenCollectionProxy::Allocate (this=0x2f6faf0, n=0) at /build/cmsbld/jenkins/workspace/build-any-ib/w/BUILD/slc6_amd64_gcc700/lcg/root/6.14.01-ebmjdi/root-6.14.01/io/io/src/TGenCollectionProxy.cxx:1179
#14 0x00007f6daa263312 in TStreamerInfo::ReadBuffer<char**> (this=0x2f9f780, b=..., arr=

in CMSSW_10_3_0_pre2 the same leads to some meaningful printouts

***********************************
*    Row   * Instance * patJets_s *
***********************************
*        0 *        0 * 136.24371 *
*        0 *        1 * 118.62297 *
*        0 *        2 * 74.196975 *
*        0 *        3 * 48.971794 *

@smuzaffar, @mrodozov please check/confirm that CMSSW_10_3_ROOT614_X_2018-08-28-2300, includes new root build with the fix from root-project/root#2488

slava77 · 2018-08-29T21:46:09Z

it looks like the new root build is not included:

which root points to /cvmfs/cms.cern.ch/slc6_amd64_gcc700/lcg/root/6.12.07-ogkkac2
ls -lh there points to Aug 17 build time, while v614: Additional fix for rule scheduling in TBranchElement root-project/root#2488 was merged on Aug 21.

slava77 · 2018-08-29T21:48:35Z

oops, sorry for the noise in the last message, I was in a wrong window. The CMSSW_10_3_ROOT614_X_2018-08-28-2300 has root from /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc700/lcg/root/6.14.01-ebmjdi and the build date there is Aug 29 from the file time stamps

slava77 · 2018-08-29T22:12:54Z

the stack trace is different from what I've see in July
Back then it was

#6   in TClass::GetRealData(char const*) const () from lib/libCore.so
#7   in TClass::GetDataMemberOffset(char const*) const () from lib/libCore.so
#8   in ROOT::read_patcLcLCandKinResolution_0(char*, TVirtualObject*) () from lib/slc6_amd64_gcc630/libDataFormatsPatCandidates.so
#9   in int TStreamerInfo::ReadBufferArtificial<char**>(TBuffer&, char** const&, TStreamerElement*, int, int) () from lib/libRIO.so

@pcanal please check if you can reproduce the problem I mentioned above #4277 (comment)

Updated root to tip of branch v6-14-00-patches

37a12df

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels Aug 21, 2018

cmsbuild added tests-started and removed tests-pending labels Aug 21, 2018

cmsbuild added tests-pending and removed tests-started labels Aug 21, 2018

mrodozov mentioned this pull request Aug 21, 2018

Tau reconstruction based on miniAOD event content cms-sw/cmssw#22594

Merged

cmsbuild added tests-started and removed tests-pending labels Aug 21, 2018

cmsbuild added tests-pending and removed tests-started labels Aug 22, 2018

cmsbuild added tests-started and removed tests-pending labels Aug 22, 2018

cmsbuild added tests-pending and removed tests-started labels Aug 24, 2018

cmsbuild removed the tests-pending label Aug 24, 2018

cmsbuild added the tests-started label Aug 24, 2018

cmsbuild added tests-rejected and removed tests-started labels Aug 24, 2018

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Aug 27, 2018

smuzaffar merged commit 54b0602 into cms-sw:IB/CMSSW_10_3_X/rootnext Aug 28, 2018

mrodozov deleted the root-update-v6-14-00-patches-20180821 branch August 30, 2018 12:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated root to tip of branch v6-14-00-patches #4277

Updated root to tip of branch v6-14-00-patches #4277

mrodozov commented Aug 21, 2018

cmsbuild commented Aug 21, 2018

mrodozov commented Aug 21, 2018

cmsbuild commented Aug 21, 2018 •

edited

mrodozov commented Aug 21, 2018

cmsbuild commented Aug 21, 2018

cmsbuild commented Aug 21, 2018 •

edited

mrodozov commented Aug 22, 2018

cmsbuild commented Aug 22, 2018 •

edited

mrodozov commented Aug 22, 2018 •

edited

davidlange6 commented Aug 24, 2018

cmsbuild commented Aug 24, 2018 •

edited

cmsbuild commented Aug 24, 2018

cmsbuild commented Aug 24, 2018

cmsbuild commented Aug 25, 2018

slava77 commented Aug 27, 2018

mrodozov commented Aug 27, 2018

mrodozov commented Aug 27, 2018

cmsbuild commented Aug 27, 2018

slava77 commented Aug 29, 2018 •

edited

slava77 commented Aug 29, 2018

slava77 commented Aug 29, 2018

slava77 commented Aug 29, 2018

Updated root to tip of branch v6-14-00-patches #4277

Updated root to tip of branch v6-14-00-patches #4277

Conversation

mrodozov commented Aug 21, 2018

cmsbuild commented Aug 21, 2018

mrodozov commented Aug 21, 2018

cmsbuild commented Aug 21, 2018 • edited

mrodozov commented Aug 21, 2018

cmsbuild commented Aug 21, 2018

cmsbuild commented Aug 21, 2018 • edited

mrodozov commented Aug 22, 2018

cmsbuild commented Aug 22, 2018 • edited

mrodozov commented Aug 22, 2018 • edited

davidlange6 commented Aug 24, 2018

cmsbuild commented Aug 24, 2018 • edited

cmsbuild commented Aug 24, 2018

cmsbuild commented Aug 24, 2018

cmsbuild commented Aug 25, 2018

slava77 commented Aug 27, 2018

mrodozov commented Aug 27, 2018

mrodozov commented Aug 27, 2018

cmsbuild commented Aug 27, 2018

slava77 commented Aug 29, 2018 • edited

slava77 commented Aug 29, 2018

slava77 commented Aug 29, 2018

slava77 commented Aug 29, 2018

cmsbuild commented Aug 21, 2018 •

edited

cmsbuild commented Aug 21, 2018 •

edited

cmsbuild commented Aug 22, 2018 •

edited

mrodozov commented Aug 22, 2018 •

edited

cmsbuild commented Aug 24, 2018 •

edited

slava77 commented Aug 29, 2018 •

edited