New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport: FastSimulation-TrackingRecHitProducer: New pixel resolution files [94X] #4324
Backport: FastSimulation-TrackingRecHitProducer: New pixel resolution files [94X] #4324
Conversation
A new Pull Request was created by @kpedro88 (Kevin Pedro) for branch IB/CMSSW_9_4_X/gcc630. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
Awesome, thanks!
…On Mon, Sep 10, 2018, 10:39 AM Kevin Pedro ***@***.***> wrote:
backport of #4196 <#4196>
Part of the ongoing FastSim backport campaign for 94X.
attn: @ssekmen <https://github.com/ssekmen>, @pmaksim1
<https://github.com/pmaksim1>
------------------------------
You can view, comment on, or merge this pull request online at:
#4324
Commit Summary
- FastSimulation-TrackingRecHitProducer: New pixel resolution files
File Changes
- *M* data-FastSimulation-TrackingRecHitProducer.spec
<https://github.com/cms-sw/cmsdist/pull/4324/files#diff-0> (2)
Patch Links:
- https://github.com/cms-sw/cmsdist/pull/4324.patch
- https://github.com/cms-sw/cmsdist/pull/4324.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4324>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEppUe29e3hf4PZy6o2Bifm0AANcludSks5uZnVOgaJpZM4WhgLb>
.
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready The workflows 1001.0, 1000.0, 140.53, 136.8311, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Comparison Summary:
|
+1 |
Do we need further checks to merge this PR? |
@smuzaffar @mrodozov please sign |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_9_4_X/gcc630 IBs (tests are also fine). This pull request will be automatically merged. |
backport of #4196
Part of the ongoing FastSim backport campaign for 94X.
attn: @ssekmen, @pmaksim1