Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: FastSimulation-TrackingRecHitProducer: New pixel resolution files [94X] #4324

Merged
merged 1 commit into from Sep 17, 2018

Conversation

kpedro88
Copy link
Contributor

backport of #4196

Part of the ongoing FastSim backport campaign for 94X.

attn: @ssekmen, @pmaksim1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 10, 2018

A new Pull Request was created by @kpedro88 (Kevin Pedro) for branch IB/CMSSW_9_4_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@pmaksim1
Copy link

pmaksim1 commented Sep 10, 2018 via email

@smuzaffar
Copy link
Contributor

smuzaffar commented Sep 11, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 11, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30321/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4324/30321/summary.html

The workflows 1001.0, 1000.0, 140.53, 136.8311, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 104
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721227
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@fabiocos
Copy link
Contributor

+1

@ssekmen
Copy link

ssekmen commented Sep 17, 2018

Do we need further checks to merge this PR?

@kpedro88
Copy link
Contributor Author

@smuzaffar @mrodozov please sign

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_9_4_X/gcc630 IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 7d22ef7 into cms-sw:IB/CMSSW_9_4_X/gcc630 Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants