Rivet 2.6.1 + Yoda 1.7.4

[mseidel42]

Open issue with loading library, see #3679

• RivetAnalyzer does not work on slc6, works only on slc7
• ParticleLevelProducer works on slc6+slc7

--> acceptable as slc6 will be phased out?

Other fixes:

• made rivet available in python so that rivet scripts work again (this should be fixed in previous releases also)
• asciidoc fails to compile documentation within CMSSW environment --> deactivated in configure script

[cmsbuild]

A new Pull Request was created by @intrepid42 (Markus Seidel) for branch IB/CMSSW_10_4_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31091/console

[cmsbuild]

-1

Tested at: 3643de9

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4427/31091/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[mseidel42]

Hi, I see that the test fails on compilation warnings. Will fix that in a CMSSW pull request.

[smuzaffar]

workflow 1325.7 also fails due to 'static TLS' issue.

[mseidel42]

Ah, I see. We run the Rivet-based ParticleLevelProducer for NanoAod there... So no reliable behavior on slc6 :(

[xjanssen]

What's missing for this PR ?

[smuzaffar]

please test

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4427/32898/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[cmsbuild]

+1
Tested at: e1744f6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4427/32917/summary.html
Additional comment: Compilation Warnings: Yes

[cmsbuild]

Comparison job queued.

[smuzaffar]

@intrepid42 , tests passed for both slc6 and slc7. Can you please a cmssw PR to fix these warnings
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4427/32898/build-logs/GeneratorInterface/RivetInterface/log.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4427/32917/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 33471 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 113727
• DQMHistoTests: Total nulls: 9
• DQMHistoTests: Total successes: 2983507
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -2.936 KiB( 31 files compared)
• DQMHistoSizes: changed ( 25202.0 ): -0.190 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 10224.0 ): 0.612 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 7.3 ): -3.358 KiB SiStrip/MechanicalView
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[mseidel42]

@smuzaffar Yes, please see cms-sw/cmssw#25817

[cmsbuild]

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#25817
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32929/console

[cmsbuild]

+1
Tested at: e1744f6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25817/32929/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4427/32929/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[smuzaffar]

+externals
FYI @fabiocos

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_5_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

@smuzaffar I understand that this version now passes also the test on slc6 (contrary to what initially stated in the explanation of this PR). There is already a fix at CMSSW level for the compilation warning, so let's test this in the IB.

@intrepid42 we have a limited test in generatorInterface/RivetInterface, in case it could be expanded with more analyses testing more features, do you see this as interesting?