New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tinyxml external, tinyxml2 used instead in cmssw #4433
Remove tinyxml external, tinyxml2 used instead in cmssw #4433
Conversation
please test |
A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_4_X/gcc700. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
The tests are being triggered in jenkins. |
-1 Tested at: d0ffc85 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testNumba had ERRORS |
Comparison job queued. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_4_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@fabiocos , @Dr15Jones: CMSSW and its externals do not use tinyxml any more. This has been replaced by tinyxml2 in cmssw. Any objection on dropping it from our externals? |
Please do drop |
Dependencies on tinyxml removed from cmssw, no externals depend on it, so we remove the external itself. Use tinyxml2 instead