Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.4.X] updated boost version 1.67 #4502

Merged
merged 1 commit into from Nov 16, 2018
Merged

Conversation

smuzaffar
Copy link
Contributor

backported from IB/CMSSW_10_4_X/gcc700next bracnh.
This version of boost has been in DEVEL IBs. Note that with this update unit test condTestRegression will fail while reading condition written using new boost (1.67) and reading with old boost (1.63 in 9.0.X).


SELF: CMSSW_10_4_DEVEL_X_2018-11-13-2300 [slc6_amd64_gcc700]

                            Write | Read: CMSSW_9_0_1 [slc6_amd64_gcc530] | Read: SELF |
  CMSSW_7_6_6 [slc6_amd64_gcc493] |                                  True |       True |
 CMSSW_8_0_26 [slc6_amd64_gcc530] |                                  True |       True |
  CMSSW_8_1_0 [slc6_amd64_gcc530] |                                  True |       True |
  CMSSW_9_0_1 [slc6_amd64_gcc530] |                                  True |       True |
                             SELF |                                 False |       True |

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_4_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31663/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 8c19d79

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4502/31663/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test condTestRegression had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@fabiocos
Copy link
Contributor

@ggovi FYI, you test should be updated, right?

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4502/31663/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013311
  • DQMHistoTests: Total failures: 286
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3012828
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31675/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 8c19d79

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4502/31675/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test condTestRegression had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4502/31675/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013311
  • DQMHistoTests: Total failures: 32
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013082
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor Author

@slava77 , @fabiocos, we are seeing comparison failures for workflow 27434.0 (HGCal). We see these errors for even trivial PRs which should not change any physics (e.g. cms-git-tools).
Can you please check if these failures are real?

@fabiocos
Copy link
Contributor

@smuzaffar I have already seen these differences in recent integration, and I was attributing to a recent update to HF GEN-SIM. But may be they are not related to that. @kpedro88 do you see any other obvious reason for this?

@slava77
Copy link
Contributor

slava77 commented Nov 16, 2018

see cms-sw/cmssw#25234
it's probably solved in cms-sw/cmssw#25257

@fabiocos
Copy link
Contributor

@slava77 ok, good, it looks anyway independent on the boost addition

@smuzaffar
Copy link
Contributor Author

thanks @slava77 . I will go ahead with the boost update then.

@smuzaffar smuzaffar merged commit 9363a10 into IB/CMSSW_10_4_X/gcc700 Nov 16, 2018
@smuzaffar smuzaffar deleted the boost-1.67 branch November 16, 2018 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants