Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.4.X] Updated root: Support new Hexagon type in TEveBoxSet + 2 fixes #4523

Merged
merged 1 commit into from Nov 25, 2018

Conversation

smuzaffar
Copy link
Contributor

Included patch cms-sw/root#117 on top on root v6.12 patches brach

…ixes

Included patch cms-sw/root#117 on top on root v6.12 patches brach
@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31811/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_4_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

-1

Tested at: 4476dd5

  • Build:

I found compilation error when building:

mkdir -p obj
g++ -std=c++11 -DPROF_VERSION="2.2.1" -Iinclude -I/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc700/external/eigen/1f44b667dd9aeeb153284b15fc7fe159d2c09329/include/eigen3 -O3 -c -fPIC src/Ipol.cc -o obj/Ipol.o
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc700/external/eigen/1f44b667dd9aeeb153284b15fc7fe159d2c09329/include/eigen3/Eigen/QR:11:0,
from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc700/external/eigen/1f44b667dd9aeeb153284b15fc7fe159d2c09329/include/eigen3/Eigen/SVD:11,
from src/Ipol.cc:2:
/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc700/external/eigen/1f44b667dd9aeeb153284b15fc7fe159d2c09329/include/eigen3/Eigen/Core:256:10: fatal error: /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc700/external/eigen/1f44b667dd9aeeb153284b15fc7fe159d2c09329/include/eigen3/Eigen/src/Core/CwiseUnaryOp.h: Input/output error
#include "src/Core/CwiseUnaryOp.h"
^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [obj/Ipol.o] Error 1
error: Bad exit status from /build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.Cj9D8i (%build)


You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4523/31811/summary.html

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31814/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 4476dd5

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4523/31814/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testSSTGainPCL_fromRECO had ERRORS
---> test condTestRegression had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4523/31814/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3131839
  • DQMHistoTests: Total failures: 160
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3131475
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 24, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31833/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 4476dd5

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4523/31833/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test condTestRegression had ERRORS
---> test testSSTGainPCL_fromRECO had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4523/31833/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3131839
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3131634
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit 53ef61f into IB/CMSSW_10_4_X/gcc700 Nov 25, 2018
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_4_X/gcc700 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants