Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: FastSimulation-TrackingRecHitProducer: New pixel resolution files [102X] #4527

Merged
merged 1 commit into from Nov 29, 2018

Conversation

kpedro88
Copy link
Contributor

backport of #4196

For FastSim backports in 102X.

attn: @ssekmen, @pmaksim1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2018

A new Pull Request was created by @kpedro88 (Kevin Pedro) for branch IB/CMSSW_10_2_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31852/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4527/31852/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007299
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007108
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_2_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@ssekmen
Copy link

ssekmen commented Nov 28, 2018

@fabiocos , can we please merge this so I can proceed with testing cms-sw/cmssw#25309 ? Thanks.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 28, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#25309
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31892/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 334da7e into cms-sw:IB/CMSSW_10_2_X/gcc700 Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants