New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build dependency on tensorflow-sources to avoid build conflicts #4566
Add build dependency on tensorflow-sources to avoid build conflicts #4566
Conversation
By default, cmsBuild tries to build tensorflow-sources and tensorflow-python3-sources in parallel, leading to conflicts with the Bazel builds. Declaring a build dependency on tensorflow-sources should force cmsBuild to build these packages one after the other.
@cmsbuild please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_10_4_X/gcc700. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
it would make sense to merge this and #4564 at the same time, since updating eigen will anyway trigger a rebuild of tensorflow. |
I understand you'll probably want this because it's a fast(er) solution, but consider we are nearly finished with tf 1.12 (see #4560). Fails only on arm (which I'm dealing with), thats why we are not adjusting cmssw already. I'm just saying this might be redundant. |
@mrodozov I'm curious, am I the only one that builds packages with |
No, https://github.com/cms-sw/cms-bot/blob/master/run-cmsdist-tests.sh#L120 but I'm not using it (out of habit) hence haven't had that trouble building tensorflow. |
OK, no problem. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
By default, cmsBuild tries to build
tensorflow-sources
andtensorflow-python3-sources
in parallel, leading to conflicts with the Bazel builds.Declaring a build dependency on
tensorflow-sources
should force cmsBuild to build these packages one after the other.