Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build dependency on tensorflow-sources to avoid build conflicts #4566

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Dec 7, 2018

By default, cmsBuild tries to build tensorflow-sources and tensorflow-python3-sources in parallel, leading to conflicts with the Bazel builds.
Declaring a build dependency on tensorflow-sources should force cmsBuild to build these packages one after the other.

By default, cmsBuild tries to build tensorflow-sources and
tensorflow-python3-sources in parallel, leading to conflicts with the
Bazel builds.
Declaring a build dependency on tensorflow-sources should force cmsBuild
to build these packages one after the other.
@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 7, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32084/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_10_4_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 7, 2018

it would make sense to merge this and #4564 at the same time, since updating eigen will anyway trigger a rebuild of tensorflow.

@mrodozov
Copy link
Contributor

mrodozov commented Dec 8, 2018

I understand you'll probably want this because it's a fast(er) solution, but consider we are nearly finished with tf 1.12 (see #4560). Fails only on arm (which I'm dealing with), thats why we are not adjusting cmssw already. I'm just saying this might be redundant.
However it's good to know building tf_src and tf_py3_src at the same time might be problematic, I'll try to trick it the same way

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 8, 2018

@mrodozov I'm curious, am I the only one that builds packages with --builders 4 or anyway more than one tool at a time ?

@mrodozov
Copy link
Contributor

mrodozov commented Dec 9, 2018

No, https://github.com/cms-sw/cms-bot/blob/master/run-cmsdist-tests.sh#L120 but I'm not using it (out of habit) hence haven't had that trouble building tensorflow.

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 9, 2018

OK, no problem.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4566/32084/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3136422
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3136217
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@smuzaffar smuzaffar merged commit 7ce8ff7 into cms-sw:IB/CMSSW_10_4_X/gcc700 Dec 13, 2018
@fwyzard fwyzard deleted the add_tensorflow_build_deps branch December 14, 2018 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants