Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #4554 to 9_4 gcc630 #4580

Merged

Conversation

mrodozov
Copy link
Contributor

Backport requested: #4554 (comment)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_9_4_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#25385
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32148/console

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_9_4_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Pull request #4580 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 14, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32206/console

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

@smuzaffar when this is merged I will move forward with cms-sw/cmssw#25385

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 27, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#25385
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32373/console

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2019

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#25385
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32469/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2019

Comparison job queued.

@fabiocos
Copy link
Contributor

fabiocos commented Jan 9, 2019

@smuzaffar any objection to merge? I will prepare a new cmssw PR with all the commits squashed

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_9_4_X/gcc630 IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 79c1db2 into IB/CMSSW_9_4_X/gcc630 Jan 9, 2019
@smuzaffar
Copy link
Contributor

no objections, I have signed it and it should be merged now.

@smuzaffar smuzaffar deleted the add-recotautag-training-data-cmsw94_gcc630 branch January 23, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants