Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get latest changes from pythia8 226 on 7_1_X #4582

Merged
merged 1 commit into from Jan 29, 2019

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Dec 13, 2018

Description: cms-externals/pythia8#13
Resolves #4581

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_7_1_X/stable.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32161/console

@cmsbuild
Copy link
Contributor

-1

Tested at: aaa3776

  • Build:

I found compilation error when building:

result = commandSpec[0](*commandSpec[1:])
File "PKGTOOLS/cmsBuild", line 3070, in installApt
File "PKGTOOLS/cmsBuild", line 3072, in installApt
File "PKGTOOLS/cmsBuild", line 220, in install_reference
RpmInstallFailed: Failed to install package herwig. Reason:
error: line 1: Tag takes single token only: Name        : external+herwig+6.521-ddibom7  Relocations: /opt/cmssw

* The action "install-external+sip-toolfile+1.0-cms2" was not completed successfully because Traceback (most recent call last):
File "/build/cmsbld/jenkins/workspace/ib-any-integration/PKGTOOLS/scheduler.py", line 199, in doSerial
result = commandSpec[0](*commandSpec[1:])
File "PKGTOOLS/cmsBuild", line 3070, in installApt


You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4582/32161/summary.html

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32162/console

@cmsbuild
Copy link
Contributor

-1

Tested at: aaa3776

  • Build:

I found compilation error when building:

result = commandSpec[0](*commandSpec[1:])
File "PKGTOOLS/cmsBuild", line 3070, in installApt
File "PKGTOOLS/cmsBuild", line 3072, in installApt
File "PKGTOOLS/cmsBuild", line 220, in install_reference
RpmInstallFailed: Failed to install package herwig. Reason:
error: line 1: Tag takes single token only: Name        : external+herwig+6.521-ddibom7  Relocations: /opt/cmssw

* The action "install-external+sip-toolfile+1.0-cms2" was not completed successfully because Traceback (most recent call last):
File "/build/cmsbld/jenkins/workspace/ib-any-integration/PKGTOOLS/scheduler.py", line 199, in doSerial
result = commandSpec[0](*commandSpec[1:])
File "PKGTOOLS/cmsBuild", line 3070, in installApt


You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4582/32162/summary.html

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32169/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4582/32604/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-4582/503.0_MinBias_13TeV_pythia8+MinBias_13TeV_pythia8+HARVESTGEN
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-4582/504.0_QCD_Pt-30_13TeV_pythia8+QCD_Pt-30_13TeV_pythia8+HARVESTGEN
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-4582/505.0_DYToLL_M-50_13TeV_pythia8+DYToLL_M-50_13TeV_pythia8+HARVESTGEN
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-4582/506.0_WToLNu_13TeV_pythia8+WToLNu_13TeV_pythia8+HARVESTGEN

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 682535
  • DQMHistoTests: Total failures: 3349
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 678812
  • DQMHistoTests: Total skipped: 374
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -10 KiB( 10 files compared)
  • Checked 44 log files, 4 edm output root files, 11 DQM output files

@alberto-sanchez
Copy link
Member

test seems ok.

@alberto-sanchez
Copy link
Member

+1

@mseidel42
Copy link
Contributor

I cannot find plots for those GEN workflows but the root files look reasonable 👍

@efeyazgan
Copy link

@intrepid42 do you think we can sign it now?

@mseidel42
Copy link
Contributor

Hi Efe, yes, I don't see any Pythia failures, so it is good to go

@Andrej-CMS
Copy link
Contributor

Dear @ALL ,
Are there any further studies required for this PR? It would be very useful to have the PSweights in 2016.
Kind regards,
Andrej

@qliphy
Copy link
Contributor

qliphy commented Jan 28, 2019

@smuzaffar We need "externals-approved" here. Can you have a look and sign if possible? We would like to have a patched 71X release for 2016 production with PSweights. Thanks!

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_7_1_X/stable IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@qliphy @efeyazgan @alberto-sanchez is this the backport into an older version of a new pythia8 feature not present in the version of 7_1_X?

@qliphy
Copy link
Contributor

qliphy commented Jan 29, 2019

@fabiocos Yes, exactly, as you can also see from cms-externals/pythia8#13
this is to bring in 7_1_X the new pythia8 feature of UncertaintyBand options

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 698e08b into IB/CMSSW_7_1_X/stable Jan 29, 2019
@smuzaffar smuzaffar deleted the update-pythia8-226 branch February 4, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants