New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get latest changes from pythia8 226 on 7_1_X #4582
Conversation
A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_7_1_X/stable. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: aaa3776
I found compilation error when building: result = commandSpec[0](*commandSpec[1:]) File "PKGTOOLS/cmsBuild", line 3070, in installApt File "PKGTOOLS/cmsBuild", line 3072, in installApt File "PKGTOOLS/cmsBuild", line 220, in install_reference RpmInstallFailed: Failed to install package herwig. Reason: error: line 1: Tag takes single token only: Name : external+herwig+6.521-ddibom7 Relocations: /opt/cmssw * The action "install-external+sip-toolfile+1.0-cms2" was not completed successfully because Traceback (most recent call last): File "/build/cmsbld/jenkins/workspace/ib-any-integration/PKGTOOLS/scheduler.py", line 199, in doSerial result = commandSpec[0](*commandSpec[1:]) File "PKGTOOLS/cmsBuild", line 3070, in installApt You can see the results of the tests here: |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: aaa3776
I found compilation error when building: result = commandSpec[0](*commandSpec[1:]) File "PKGTOOLS/cmsBuild", line 3070, in installApt File "PKGTOOLS/cmsBuild", line 3072, in installApt File "PKGTOOLS/cmsBuild", line 220, in install_reference RpmInstallFailed: Failed to install package herwig. Reason: error: line 1: Tag takes single token only: Name : external+herwig+6.521-ddibom7 Relocations: /opt/cmssw * The action "install-external+sip-toolfile+1.0-cms2" was not completed successfully because Traceback (most recent call last): File "/build/cmsbld/jenkins/workspace/ib-any-integration/PKGTOOLS/scheduler.py", line 199, in doSerial result = commandSpec[0](*commandSpec[1:]) File "PKGTOOLS/cmsBuild", line 3070, in installApt You can see the results of the tests here: |
please test |
The tests are being triggered in jenkins. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
test seems ok. |
+1 |
I cannot find plots for those GEN workflows but the root files look reasonable 👍 |
@intrepid42 do you think we can sign it now? |
Hi Efe, yes, I don't see any Pythia failures, so it is good to go |
Dear @ALL , |
@smuzaffar We need "externals-approved" here. Can you have a look and sign if possible? We would like to have a patched 71X release for 2016 production with PSweights. Thanks! |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_7_1_X/stable IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@qliphy @efeyazgan @alberto-sanchez is this the backport into an older version of a new pythia8 feature not present in the version of 7_1_X? |
@fabiocos Yes, exactly, as you can also see from cms-externals/pythia8#13 |
+1 |
Description: cms-externals/pythia8#13
Resolves #4581