Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions of python tools - fix tauolapp source location #4683

Merged
merged 8 commits into from Feb 21, 2019

Conversation

davidlange6
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2019

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_10_5_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33032/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2019

Pull request #4683 was updated.

@davidlange6
Copy link
Contributor Author

davidlange6 commented Feb 7, 2019 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2019

Pull request #4683 was updated.

@davidlange6
Copy link
Contributor Author

davidlange6 commented Feb 7, 2019 via email

tauolapp.spec Outdated Show resolved Hide resolved
@cms-sw cms-sw deleted a comment from cmsbuild Feb 7, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33035/console

Apparently pytables is not yet ready for 1.16 (a fix is in their repo but not released)
@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 14, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33128/console

@cmsbuild
Copy link
Contributor

Pull request #4683 was updated.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4683/33128/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_5_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

@fabiocos , we overlooked this PR yesterday. If it still time in pre2 then can we get this in?

@davidlange6
Copy link
Contributor Author

davidlange6 commented Feb 19, 2019 via email

@fabiocos
Copy link
Contributor

@davidlange6 @smuzaffar I wanted to clarify today at the ORP. While cms-sw/cmssw#25890 seems orthogonal to the standard workflows, this update may be less innocent. As I hope to converge asap to pre2, I would keep a decision about its merge for this evening.

@davidlange6
Copy link
Contributor Author

davidlange6 commented Feb 19, 2019 via email

@mrodozov mrodozov changed the base branch from IB/CMSSW_10_5_X/gcc700 to IB/CMSSW_10_6_X/gcc700 February 21, 2019 14:01
@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ab6cf5b into cms-sw:IB/CMSSW_10_6_X/gcc700 Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants