New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update versions of python tools - fix tauolapp source location #4683
Conversation
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_10_5_X/gcc700. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
Pull request #4683 was updated. |
i probably have one more update later - i'll restart tests when I'm more likely stopped
… On Feb 7, 2019, at 1:13 PM, cmsbuild ***@***.***> wrote:
Pull request #4683 was updated.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Pull request #4683 was updated. |
The tests are being triggered in jenkins. |
Apparently pytables is not yet ready for 1.16 (a fix is in their repo but not released)
please test |
The tests are being triggered in jenkins. |
Pull request #4683 was updated. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_5_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@fabiocos , we overlooked this PR yesterday. If it still time in pre2 then can we get this in? |
I would suggest merging this after pre2 unless pre2 is known to be delayed for several more days.. i should not affect anything, but it can.
… On Feb 19, 2019, at 9:44 AM, Malik Shahzad Muzaffar ***@***.***> wrote:
@fabiocos , we overlooked this PR yesterday. If it still time in pre2 then can we get this in?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@davidlange6 @smuzaffar I wanted to clarify today at the ORP. While cms-sw/cmssw#25890 seems orthogonal to the standard workflows, this update may be less innocent. As I hope to converge asap to pre2, I would keep a decision about its merge for this evening. |
it won't affect standard workflows. but perhaps some tests (If i missed something). its just a matter of not wanting to delay pre2 for non-critical path things. (but given 48 hours more of delay, then this PR is a good target)
… On Feb 19, 2019, at 9:56 AM, Fabio Cossutti ***@***.***> wrote:
@davidlange6 @smuzaffar I wanted to clarify today at the ORP. While cms-sw/cmssw#25890 seems orthogonal to the standard workflows, this update may be less innocent. As I hope to converge asap to pre2, I would keep a decision about its merge for this evening.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
+1 |
No description provided.