Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMSCodeChecker #4715

Merged
merged 2 commits into from Mar 20, 2019
Merged

Conversation

gartung
Copy link
Member

@gartung gartung commented Feb 19, 2019

The initial version of this clang-tidy checker rewrites getByToken(EDGetTokenT, Handle calls as Handle = getHandle(EDGetTokenT).

Like clang-tidy this requires compile-command.json. Run with
CMScodecheck -checks='-*,cms-handle'

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for branch IB/CMSSW_10_5_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@mrodozov mrodozov changed the base branch from IB/CMSSW_10_5_X/gcc700 to IB/CMSSW_10_6_X/gcc700 February 21, 2019 13:58
@cmsbuild
Copy link
Contributor

Pull request #4715 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33686/console

@smuzaffar
Copy link
Contributor

abort
@gartung can you please also add codechecker-toolfile in cmssw-toolconf.spec

@cmsbuild
Copy link
Contributor

Jenkins tests are aborted.

@gartung
Copy link
Member Author

gartung commented Mar 20, 2019

Done

@cmsbuild
Copy link
Contributor

Pull request #4715 was updated.

@smuzaffar
Copy link
Contributor

please test
thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33687/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4715/33687/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3114829
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3114631
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor

+externals
its a new external for cms checks and none of cmssw code depends on it, so merging it for next IB

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@gartung gartung deleted the codechecker branch May 4, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants