Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch IB/CMSSW_10_6_X/gcc700 - Cherry-picked 6c1e592 from root pr. #4745

Merged
merged 1 commit into from Mar 2, 2019

Conversation

gudrutis
Copy link
Contributor

@gudrutis gudrutis commented Mar 1, 2019

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2019

A new Pull Request was created by @gudrutis (Zygimantas Matonis) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@gudrutis
Copy link
Contributor Author

gudrutis commented Mar 1, 2019

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33360/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4745/33360/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3114826
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3114628
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor

+externals
@Dr15Jones this includes the ROOT root-project/root#3485 fix for our normal IBs (i.e. root 6.12 based IBs).
@fabiocos , any objection on merging this?

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2019

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 2, 2019

+1

there is no other external merge I plan, so let's try it now

@cmsbuild cmsbuild merged commit 44481ad into IB/CMSSW_10_6_X/gcc700 Mar 2, 2019
@smuzaffar smuzaffar deleted the pr-3-cherry-pick branch March 2, 2019 08:55
@Dr15Jones
Copy link

@smuzaffar which IBs have this change?

@smuzaffar
Copy link
Contributor

@Dr15Jones, CMSSW_10_6_X_2019-03-03-0000 and above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants