Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.6.X] update tkonlinesw-fake to implement extra symbols #4749

Merged
merged 1 commit into from Mar 5, 2019

Conversation

smuzaffar
Copy link
Contributor

cmssw aarch64 IBs fails to build due to following issing symbols. This PR provides these symbols via tkonlnesw-fake package

  CalibrationHistosUsingDb.cc:(.text+0x828): undefined reference to `apvDescription::getIsha()'
   CalibrationHistosUsingDb.cc:(.text+0x850): undefined reference to `apvDescription::getVfs()'

cms-externals/tkonlinesw-fake@97afe74

cmssw aarch64 IBs fails to build due to following issing symbols. This PR provides these symbols via tkonlnesw-fake package
```
  CalibrationHistosUsingDb.cc:(.text+0x828): undefined reference to `apvDescription::getIsha()'
   CalibrationHistosUsingDb.cc:(.text+0x850): undefined reference to `apvDescription::getVfs()'
```

cms-externals/tkonlinesw-fake@97afe74
@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33403/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar
Copy link
Contributor Author

+externals
tkonlinesw-fake is only used by aarch64 IBs where we do not have oracle and tools which depends on oracle (tkonlinesw is one of them).

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

Comparison job queued.

@smuzaffar
Copy link
Contributor Author

merging it for 11h aarch64 IBs.

@smuzaffar smuzaffar merged commit eb28f1d into IB/CMSSW_10_6_X/gcc700 Mar 5, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4749/33403/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3114826
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3114628
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@smuzaffar smuzaffar deleted the smuzaffar-patch-3 branch March 8, 2019 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants