New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gcc version to 7.4.1 #4846
Conversation
A new Pull Request was created by @fabiocos (Fabio Cossutti) for branch IB/CMSSW_10_6_X/gcc700. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
@smuzaffar is this test going to rebuild everything? Basically this is already done in the DEVEL_X IB, not sure we really need it... |
@fabiocos , for externals it is going to reuse all the pre-build packages but yes for cmssw it is going to rebuild every thing. I agree we do not need the test but does not hurt much |
@smuzaffar ok let it run, this will provide anyway the comparison which is useful to see |
BTW, pre-build with the new gcc? I guess not, while this is done in DEVEL_X... |
yes, as architecture is same (slc7_amd64_gcc700) so what ever has been build by DEVEL IBs will be reused by normal IBs. Ideally no external package should be rebuild. |
-1 Tested at: ad57e6c You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
please test |
The tests are being triggered in jenkins. |
please abort not sure that the bot is in the correct state |
Jenkins tests are aborted. |
bot is in correct state and I have restarted tests (for those which were using bad bot). I did not realized that you already have revert the change. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
I have performed the following test: rerun wf 9 starting from either step1 or step2 produced with the default CMSSW (gcc730). Rerunning the DQM comparison with the baseline in the former case I see
and in the latter
So this confirms that the non reproducibility is located in the simulation part, and not only at GEN-SIM level. |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@smuzaffar I have put the discussion about this PR in agenda for next ORP, I would like to merge it after that |
+1 |
@smuzaffar we are not tracking minor version update in the architecture name (it was gcc700 already with gcc 731...), am I correct? |
that is correct @fabiocos |
Update gcc version to 7.4.1 already running in the DEVEL_X IB without apparent problems