Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update python packages and xtensor #4887

Merged
merged 2 commits into from Apr 17, 2019

Conversation

davidlange6
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 16, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34231/console

@cmsbuild
Copy link
Contributor

-1

Tested at: ae5e317

  • Build:

I found compilation warning when building: See details on the summary page.

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4887/34231/summary.html

remove deepdish dependency
@cmsbuild
Copy link
Contributor

Pull request #4887 was updated.

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 16, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34232/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 60540c7

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4887/34232/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testImports had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4887/34232/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3142783
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3142585
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@davidlange6
Copy link
Contributor Author

unit test fixed by cms-sw/cmssw#26475
I'd suggest we merge both after the trivial tests pass on both @fabiocos

@davidlange6
Copy link
Contributor Author

(correction, I don't mean to suggest rerunning tests on the cmsdist PR - that takes all night for just checking unit test)

@fabiocos
Copy link
Contributor

@davidlange6 what about https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_10_6_X/gcc700/pip/py2-deepdish.file ? At this point I would say it is not needed either, am I correct? Probably it does not harm as it is used if the entry is present in the requirements file

https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_10_6_X/gcc700/pip/cmsdist_packages.py#L4

and you have removed it...

@fabiocos
Copy link
Contributor

@mrodozov FYI I would like merge this for next IB (with cms-sw/cmssw#26475)

@mrodozov
Copy link
Contributor

@fabiocos go ahead

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit b3d7775 into cms-sw:IB/CMSSW_10_6_X/gcc700 Apr 17, 2019
@mrodozov
Copy link
Contributor

I'm going to put condition for numpy as the 1.16.2 doesn't build on arm

00:21:04 numpy/core/src/npymath/npy_math_internal.h.src: In function 'npy_cacoshf':
00:21:04 numpy/core/src/npymath/npy_math_internal.h.src:482:12: internal compiler error: Segmentation fault
00:21:04 return @kind@@c@(x, y);

@davidlange6
Copy link
Contributor Author

davidlange6 commented Apr 18, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants