Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BuildRules] Fixed quotation for compile_commands.json #4979

Merged
merged 1 commit into from May 16, 2019

Conversation

smuzaffar
Copy link
Contributor

Use correct quotations e.g.

-DPROJECT_NAME='\"CMSSW\"'

instead of

-DPROJECT_NAME=\"CMSSW\"

to avoid compilation errors during code-checks

L1MuGMTParametersOnlineProducer.cc:118:65: error: expected ')' [clang-diagnostic-error]
	edm::LogInfo("No CMSSW version set in database, accepting " PROJECT_VERSION);
                                                                                                            ^
note: expanded from here

Use correct quotations e.g.
```
-DPROJECT_NAME='\"CMSSW\"'
```
instead of
```
-DPROJECT_NAME=\"CMSSW\"
```
to avoid compilation errors during code-checks
```
L1MuGMTParametersOnlineProducer.cc:118:65: error: expected ')' [clang-diagnostic-error]
	edm::LogInfo("No CMSSW version set in database, accepting " PROJECT_VERSION);
                                                                                                            ^
note: expanded from here
```
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_0_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/260/console Started: 2019/05/16 15:30

@cmsbuild
Copy link
Contributor

-1

Tested at: c1bad35

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b291a9/260/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

4.53 step2
runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@smuzaffar
Copy link
Contributor Author

errors are due to eos

@smuzaffar smuzaffar merged commit 556ad16 into IB/CMSSW_11_0_X/gcc700 May 16, 2019
@smuzaffar smuzaffar deleted the smuzaffar-patch-11 branch May 19, 2019 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants