Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhysicsTools-NanoAOD: Adding low pt muon MVA weights #4995

Merged
merged 1 commit into from May 21, 2019

Conversation

smuzaffar
Copy link
Contributor

resolves #4984
as requested here cms-data/PhysicsTools-NanoAOD#6

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_0_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar
Copy link
Contributor Author

+externals
already tested via cms-data/PhysicsTools-NanoAOD#6

@cmsbuild
Copy link
Contributor

cmsbuild commented May 21, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/384/console Started: 2019/05/21 18:41

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/gcc700 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 21, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#26844,cms-sw/cmssw#26724
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/387/console Started: 2019/05/21 20:45

@fabiocos
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

-1

Tested at: 2dc9556

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0acc433
57a8ca3
7f9a42e
2e5a83a
39fd3ae
ab7be41
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4995/387/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4995/387/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-886027/387/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
136.8521 step2

runTheMatrix-results/136.8521_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018_102Xv1+HARVESTNANOAOD2018_102Xv1/step2_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018_102Xv1+HARVESTNANOAOD2018_102Xv1.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0acc433
57a8ca3
7f9a42e
2e5a83a
39fd3ae
ab7be41
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4995/387/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4995/387/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 21, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#26844,cms-sw/cmssw#26724
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/394/console Started: 2019/05/22 00:10

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-886027/394/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 136 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3206828
  • DQMHistoTests: Total failures: 93
  • DQMHistoTests: Total nulls: 9
  • DQMHistoTests: Total successes: 3206392
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 25.727 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 1325.7 ): 25.727 KiB Physics/NanoAODDQM
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cms-data/PhysicsTools-NanoAOD#6: Adding low pt muon MVA weights
3 participants