Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rivet 2.7.2 and YODA 1.75 #5005

Merged

Conversation

mseidel42
Copy link
Contributor

Rivet and YODA minor revision updates

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @intrepid42 (Markus Seidel) for branch IB/CMSSW_11_0_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor

allow @intrepid42 test rights

@mrodozov
Copy link
Contributor

now you can test the PR and retry it if it needs retriggering

@mseidel42
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 24, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/487/console Started: 2019/05/24 12:05

@cmsbuild
Copy link
Contributor

-1

Tested at: 4349842

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecb0cb/487/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-23-2300/src/GeneratorInterface/RivetInterface/plugins/GenParticles2HepMCConverter.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-23-2300/src/GeneratorInterface/RivetInterface/plugins/MergedGenParticleProducer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-23-2300/src/GeneratorInterface/RivetInterface/plugins/DQMRivetClient.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-23-2300/src/GeneratorInterface/RivetInterface/plugins/HTXSRivetProducer.cc 
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-23-2300/src/GeneratorInterface/RivetInterface/plugins/RivetAnalyzer.cc: In constructor 'RivetAnalyzer::RivetAnalyzer(const edm::ParameterSet&)':
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-23-2300/src/GeneratorInterface/RivetInterface/plugins/RivetAnalyzer.cc:50:29: error: 'CmpAnaHandle' was not declared in this scope
   const std::set& analyses = _analysisHandler.analyses();
                             ^~~~~~~~~~~~
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-23-2300/src/GeneratorInterface/RivetInterface/plugins/RivetAnalyzer.cc:50:41: error: template argument 2 is invalid
   const std::set& analyses = _analysisHandler.analyses();
                                         ^


@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@mseidel42
Copy link
Contributor Author

@mseidel42
Copy link
Contributor Author

please test with cms-sw/cmssw#26936

@cmsbuild
Copy link
Contributor

cmsbuild commented May 24, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#26936
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/503/console Started: 2019/05/24 18:25

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc490d/503/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3206856
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3206521
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor

@smuzaffar ok for me to move forward at next IB

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 12db8d6 into cms-sw:IB/CMSSW_11_0_X/gcc700 May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants