Updated root to tip of branch v6-16-00-patches

[smuzaffar]

No description provided.

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/559/console Started: 2019/05/28 23:17

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_0_X/rootnext.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 70f4c1b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-165523/559/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-165523/559/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3209232
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3208896
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[smuzaffar]

+externals
@fabiocos , @slava77 can you please confirm is the comparison looks good here?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/rootnext IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[slava77]

+externals
@fabiocos , @slava77 can you please confirm is the comparison looks good here?

It's worth to check the logwarnings in 158.0, where differences are reported.
What is the right link to the directory with the baseline matrix outputs?

[smuzaffar]

@slava77 , baseline IB relval results are available https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-baseline-tests/CMSSW_11_0_X_2019-05-27-2300/
We will fix the link to point to correct baseline in the summary page.

[slava77]

The extra warning in the step3 of 158.0 is

%MSG-e ExcessiveTime:  PhotonValidator:pfPhotonValidation  29-May-2019 06:27:21 CEST Run: 1 Event: 1
ExcessiveTime: Module used 708.572 seconds of time which exceeds the error threshold configured in the Timing Service of 600 seconds.

this looks mildly suspicious

[fabiocos]

@slava77 @smuzaffar in the PR test the TimingService is active, please check in the JobReport.xml for its output. But I see this is not true in the baseline...

[slava77]

In the baseline the 1st event processing starts at 00:25:35 and the file is closed at 00:26:57.
So, the time spent in pfPhotonValidation in the baseline is certainly less than in this PR.

[fabiocos]

please test

@slava77 in a standalone test with the TimeReport per module I could not see anything strange...

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/662/console Started: 2019/05/31 18:35

[cmsbuild]

+1
Tested at: 70f4c1b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-165523/662/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-165523/662/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3210678
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3210342
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[fabiocos]

@smuzaffar @slava77 in the new test it does not seem to me there were odd timing issues