Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onnxruntime #5080

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Jul 8, 2019

As discussed in cms-sw/cmssw#27458.

@davidlange6 This builds only the C API -- but the python package might also be helpful if analyzers want to run some ML inference in their python-based analyses.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2019

A new Pull Request was created by @hqucms (Huilin Qu) for branch IB/CMSSW_11_0_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

(the cmake update is indeed required - that will rebuild lots of things I suspect)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1358/console Started: 2019/07/08 15:40

onnxruntime.spec Outdated
-Donnxruntime_USE_FULL_PROTOBUF=OFF \
-Donnxruntime_DISABLE_CONTRIB_OPS=OFF \
-Donnxruntime_BUILD_UNIT_TESTS=OFF \
../cmake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see any specifics for the build architecture.
What does this default to? We still need to restrict to SSE4 (or is it SSE3?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that it supports dynamic architecture -- I built it once on a machine with AVX and it runs fine on another machine without it.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2019

-1

Tested at: 005f931

  • Build:

I found compilation error when building:

linked by target "igprof" in directory /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/external/igprof/5.9.16-cms/igprof-4235186fd1a9b9adb86a8a45bb7a8ece74953039

-- Configuring incomplete, errors occurred!
See also "/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/external/igprof/5.9.16-cms/igprof-4235186fd1a9b9adb86a8a45bb7a8ece74953039/CMakeFiles/CMakeOutput.log".
See also "/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/external/igprof/5.9.16-cms/igprof-4235186fd1a9b9adb86a8a45bb7a8ece74953039/CMakeFiles/CMakeError.log".
error: Bad exit status from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.IFpsKn (%build)


RPM build errors:
Bad exit status from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.IFpsKn (%build)



You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c31479/1358/summary.html

@hqucms
Copy link
Contributor Author

hqucms commented Jul 9, 2019

I cannot reproduce the error -- igprof builds fine with the cmake update on my side.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1371/console Started: 2019/07/09 16:00

@smuzaffar
Copy link
Contributor

@hqucms , the build error is this. May be you have unwind installed on the system that is why cmake did not fail.

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
UNWIND_INCLUDE_DIR

@smuzaffar
Copy link
Contributor

During PR tests we create symlink for packages which are not changed. In this case we create symlink for unwwind. I think problem is here
https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_11_0_X/gcc700/igprof.spec#L16
which just rsync symlink instead of contents of unwind and atoim_ops. I am looking in to this now.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2019

-1

Tested at: 005f931

  • Build:

I found compilation error when building:

linked by target "igprof" in directory /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/external/igprof/5.9.16-cms/igprof-4235186fd1a9b9adb86a8a45bb7a8ece74953039

-- Configuring incomplete, errors occurred!
See also "/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/external/igprof/5.9.16-cms/igprof-4235186fd1a9b9adb86a8a45bb7a8ece74953039/CMakeFiles/CMakeOutput.log".
See also "/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/external/igprof/5.9.16-cms/igprof-4235186fd1a9b9adb86a8a45bb7a8ece74953039/CMakeFiles/CMakeError.log".
error: Bad exit status from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.G0vmFi (%build)


RPM build errors:
Bad exit status from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.G0vmFi (%build)



You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c31479/1371/summary.html

@hqucms
Copy link
Contributor Author

hqucms commented Jul 9, 2019

During PR tests we create symlink for packages which are not changed. In this case we create symlink for unwwind. I think problem is here
https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_11_0_X/gcc700/igprof.spec#L16
which just rsync symlink instead of contents of unwind and atoim_ops. I am looking in to this now.

@smuzaffar Thank you for looking into this! Indeed when I built igprof, unwind was downloaded rather than symlinked, which is probably why it built successfully on my machine.

@cmsbuild
Copy link
Contributor

Pull request #5080 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c31479/1882/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 2715989
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2715658
  • DQMHistoTests: Total skipped: 329
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1885/console Started: 2019/08/08 08:32

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c31479/1885/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 2715989
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2715659
  • DQMHistoTests: Total skipped: 329
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 5a314f4 into cms-sw:IB/CMSSW_11_0_X/gcc700 Aug 8, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

@hqucms , this is now available in CMSSW_11_0_X IBs. Note that occxruntime currently does not support PowerPC so that is why it is not available for ppc64le SCRAM ARCH IBs.

@hqucms
Copy link
Contributor Author

hqucms commented Aug 9, 2019

@smuzaffar Thank you very much! I will test occxruntime from the IBs and proceed from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants