New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onnxruntime #5080
Add onnxruntime #5080
Conversation
please test (the cmake update is indeed required - that will rebuild lots of things I suspect) |
The tests are being triggered in jenkins. |
onnxruntime.spec
Outdated
-Donnxruntime_USE_FULL_PROTOBUF=OFF \ | ||
-Donnxruntime_DISABLE_CONTRIB_OPS=OFF \ | ||
-Donnxruntime_BUILD_UNIT_TESTS=OFF \ | ||
../cmake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see any specifics for the build architecture.
What does this default to? We still need to restrict to SSE4 (or is it SSE3?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that it supports dynamic architecture -- I built it once on a machine with AVX and it runs fine on another machine without it.
-1 Tested at: 005f931
I found compilation error when building: linked by target "igprof" in directory /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/external/igprof/5.9.16-cms/igprof-4235186fd1a9b9adb86a8a45bb7a8ece74953039 -- Configuring incomplete, errors occurred! See also "/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/external/igprof/5.9.16-cms/igprof-4235186fd1a9b9adb86a8a45bb7a8ece74953039/CMakeFiles/CMakeOutput.log". See also "/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/external/igprof/5.9.16-cms/igprof-4235186fd1a9b9adb86a8a45bb7a8ece74953039/CMakeFiles/CMakeError.log". error: Bad exit status from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.IFpsKn (%build) RPM build errors: Bad exit status from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.IFpsKn (%build) You can see the results of the tests here: |
I cannot reproduce the error -- igprof builds fine with the cmake update on my side. |
please test |
The tests are being triggered in jenkins. |
@hqucms , the build error is this. May be you have unwind installed on the system that is why cmake did not fail.
|
During PR tests we create symlink for packages which are not changed. In this case we create symlink for unwwind. I think problem is here |
-1 Tested at: 005f931
I found compilation error when building: linked by target "igprof" in directory /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/external/igprof/5.9.16-cms/igprof-4235186fd1a9b9adb86a8a45bb7a8ece74953039 -- Configuring incomplete, errors occurred! See also "/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/external/igprof/5.9.16-cms/igprof-4235186fd1a9b9adb86a8a45bb7a8ece74953039/CMakeFiles/CMakeOutput.log". See also "/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/external/igprof/5.9.16-cms/igprof-4235186fd1a9b9adb86a8a45bb7a8ece74953039/CMakeFiles/CMakeError.log". error: Bad exit status from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.G0vmFi (%build) RPM build errors: Bad exit status from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.G0vmFi (%build) You can see the results of the tests here: |
@smuzaffar Thank you for looking into this! Indeed when I built igprof, unwind was downloaded rather than symlinked, which is probably why it built successfully on my machine. |
Pull request #5080 was updated. |
Comparison is ready Comparison Summary:
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@hqucms , this is now available in CMSSW_11_0_X IBs. Note that occxruntime currently does not support PowerPC so that is why it is not available for ppc64le SCRAM ARCH IBs. |
@smuzaffar Thank you very much! I will test occxruntime from the IBs and proceed from there. |
As discussed in cms-sw/cmssw#27458.
@davidlange6 This builds only the C API -- but the python package might also be helpful if analyzers want to run some ML inference in their python-based analyses.