New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enables sized-deallocation for llvm #5113
Conversation
`-fsized-deallocation` is enabled by default by GCC under -std=c++14 and above. PyBind11 version 2.3.0 make use of this but as clang does not enable it by default so CMSSW CLANG build are failing. ``` In file included from FWCore/PyDevParameterSet/interface/Python11ParameterSet.h:3: py2-pybind11/2.3.0/include/python2.7/pybind11/pybind11.h:1009:9: error: no matching function for call to 'operator delete' ::operator delete(p, s, std::align_val_t(a)); ^~~~~~~~~~~~~~~~~ ``` This PR suggest to enable sized-deallocation for clang too
please test for CMSSW_11_0_CLANG_X |
The tests are being triggered in jenkins. |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_0_X/gcc700. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
-1 Tested at: d279b0d You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test test_MpsWorkFlow had ERRORS |
Comparison job queued. |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/gcc700 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison is ready Comparison Summary:
|
-fsized-deallocation
is enabled by default by GCC under -std=c++14 and above. PyBind11 version 2.3.0 makes use of this ( https://github.com/pybind/pybind11/blob/v2.3/include/pybind11/pybind11.h#L1006) but as clang does not enable sized-deallocation` by default so CMSSW CLANG builds are failing.This PR suggest to enable sized-deallocation for clang too