Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enables sized-deallocation for llvm #5113

Merged
merged 1 commit into from Jul 29, 2019

Conversation

smuzaffar
Copy link
Contributor

-fsized-deallocation is enabled by default by GCC under -std=c++14 and above. PyBind11 version 2.3.0 makes use of this ( https://github.com/pybind/pybind11/blob/v2.3/include/pybind11/pybind11.h#L1006) but as clang does not enable sized-deallocation` by default so CMSSW CLANG builds are failing.

In file included from FWCore/PyDevParameterSet/interface/Python11ParameterSet.h:3:
  py2-pybind11/2.3.0/include/python2.7/pybind11/pybind11.h:1009:9: error: no matching function for call to 'operator delete'
         ::operator delete(p, s, std::align_val_t(a));
        ^~~~~~~~~~~~~~~~~

This PR suggest to enable sized-deallocation for clang too

`-fsized-deallocation` is enabled by default by GCC under -std=c++14 and above. PyBind11 version 2.3.0 make use of this but as clang does not enable it by default so CMSSW CLANG build are failing. 
```
In file included from FWCore/PyDevParameterSet/interface/Python11ParameterSet.h:3:
  py2-pybind11/2.3.0/include/python2.7/pybind11/pybind11.h:1009:9: error: no matching function for call to 'operator delete'
         ::operator delete(p, s, std::align_val_t(a));
        ^~~~~~~~~~~~~~~~~
```
This PR suggest to enable sized-deallocation for clang too
@smuzaffar
Copy link
Contributor Author

please test for CMSSW_11_0_CLANG_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 29, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1687/console Started: 2019/07/29 17:31

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_0_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Tested at: d279b0d

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5d659/1687/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test test_MpsWorkFlow had ERRORS
---> test ExpressionEvaluatorUnitTest had ERRORS
---> test testExpressionEvaluator had ERRORS
---> test runtestTqafTopJetCombination had ERRORS
---> test runtestTqafTopEventSelection had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Jul 29, 2019

+externals
looks good for clang IBs.

@smuzaffar smuzaffar merged commit 79c2161 into IB/CMSSW_11_0_X/gcc700 Jul 29, 2019
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/gcc700 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5d659/1687/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11114 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2628546
  • DQMHistoTests: Total failures: 33030
  • DQMHistoTests: Total nulls: 5
  • DQMHistoTests: Total successes: 2595194
  • DQMHistoTests: Total skipped: 317
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.012 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 4.53 ): 0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 136.85 ): 0.008 KiB JetMET/SUSYDQM
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants