Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates pip based packages #5256

Merged
merged 3 commits into from Oct 7, 2019
Merged

Conversation

smuzaffar
Copy link
Contributor

  • new versions for pip based python packages
  • Use --upgrade --upgrade-strategy only-if-needed to make sure that we always install a package in our externals area.
  • Cleanup for py2 and py3 packages
  • Cleanup of some unused files
  • Create lib/py3 for llvm
  • Build xrootd for both python2 and python3
  • Build numpy, matplotlib and tensorflow using our build-with-pip system.
  • Build dxr for py3
  • Get cx-Oracle from pip and install it for both py2 and py3

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2754/console Started: 2019/10/02 15:49

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2019

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2756/console Started: 2019/10/02 15:58

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2019

Pull request #5256 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2019

-1

Tested at: cc974fe

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e81285/2756/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testTheano had ERRORS
---> test testImports had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e81285/2756/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2956833
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2956491
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e81285/2780/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2961049
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2960706
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2019

-1

Tested at: f9dd471

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e81285/2796/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test test_MpsWorkFlow had ERRORS
---> test testPyDevParameterSet had ERRORS
---> test testTauEmbeddingProducers had ERRORS
---> test ExpressionEvaluatorUnitTest had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e81285/2796/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2961049
  • DQMHistoTests: Total failures: 129
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2960579
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2019

-1

Tested at: f9dd471

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e81285/2801/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test test_MpsWorkFlow had ERRORS
---> test ExpressionEvaluatorUnitTest had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e81285/2801/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2961049
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2960706
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Oct 6, 2019

+externals
failing unit tests has nothing to do with this change. Unit tests itself need fixing.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2019

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants