Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data-SimPPS-PPSPixelDigiProducer to cmsswdata.spec #5270

Merged

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Oct 9, 2019

The recent integration of #5262 has missed the update of cmsswdata.spec (it was the first addition, I believe that was the reason). As a result in CMSSW_11_0_X_2019-10-09-1100 there is no data file in $CMSSW_DATA_PATH/. This PR is meant to fix this

@mundim FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2019

A new Pull Request was created by @fabiocos (Fabio Cossutti) for branch IB/CMSSW_11_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

@smuzaffar any objection or issue you see with this?

@fabiocos
Copy link
Contributor Author

+1

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 10, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2868/console Started: 2019/10/10 11:32

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/master IBs after it passes the integration tests.

@smuzaffar smuzaffar merged commit 29963bd into cms-sw:IB/CMSSW_11_0_X/master Oct 10, 2019
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7ab58/2868/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2961056
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2960714
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants