Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport OpenBLAS fixes [10_6_X] #5291

Merged
merged 2 commits into from Nov 7, 2019

Conversation

kpedro88
Copy link
Contributor

This is a combined backport of #5063 and #5091. The goal is to propagate the DeepAK8 speedup to the ultra legacy release (for both production and analysis).

attn: @hqucms @smuzaffar @slava77

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 21, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3066/console Started: 2019/10/21 21:43

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01236e/3066/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212305
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211969
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Nov 6, 2019

@kpedro88 besides the impact on DeepAK8 this is impacting also some generators, where the BLAS version by gsl is replaced by OpenBLAS. I do not recall we observed any problem related to this, but it is good that @qliphy @agrohsje are aware of this

@fabiocos
Copy link
Contributor

fabiocos commented Nov 6, 2019

please test workflow 511.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3365/console Started: 2019/11/06 11:44

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2019

-1

Tested at: ae0f9e9

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01236e/3365/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test TestRunnerFWCoreTFWLiteSelector had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01236e/3365/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-01236e/511.0_QCD_Pt-30_13TeV_aMCatNLO_herwig7+QCD_Pt-30_13TeV_aMCatNLO_herwig7+HARVESTGEN

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211989
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Nov 7, 2019

@smuzaffar the error in the unit test seems to be disconnected to this PR (likely a transient issue we see from time to time)

@fabiocos
Copy link
Contributor

fabiocos commented Nov 7, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Nov 7, 2019

merge

@cmsbuild cmsbuild merged commit f1de63c into cms-sw:IB/CMSSW_10_6_X/gcc700 Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants