Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename py2-dablooms to dablooms. Remove dablooms python binding. #5315

Merged
merged 3 commits into from Nov 4, 2019
Merged

Rename py2-dablooms to dablooms. Remove dablooms python binding. #5315

merged 3 commits into from Nov 4, 2019

Conversation

gartung
Copy link
Member

@gartung gartung commented Oct 30, 2019

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for branch IB/CMSSW_11_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #5315 was updated.

@gartung
Copy link
Member Author

gartung commented Oct 30, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 30, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3248/console Started: 2019/10/30 13:52

@gartung
Copy link
Member Author

gartung commented Oct 30, 2019

abort

@cmsbuild
Copy link
Contributor

Jenkins tests are aborted.

@cmsbuild
Copy link
Contributor

Pull request #5315 was updated.

@gartung
Copy link
Member Author

gartung commented Oct 30, 2019

test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 30, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3250/console Started: 2019/10/30 14:04

@gartung
Copy link
Member Author

gartung commented Oct 30, 2019

abort

@cmsbuild
Copy link
Contributor

Jenkins tests are aborted.

@gartung
Copy link
Member Author

gartung commented Oct 30, 2019

test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 30, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3252/console Started: 2019/10/30 14:31

@cmsbuild
Copy link
Contributor

Pull request #5315 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019

Pull request #5315 was updated.

@gartung
Copy link
Member Author

gartung commented Nov 1, 2019

test with cms-sw/cmssw#28315

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#28315
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3302/console Started: 2019/11/01 17:13

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4231be/3299/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939026
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2938683
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019

+1
Tested at: 4a770f7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d53436/3302/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d53436/3302/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939026
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2938683
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Nov 4, 2019

+1

@cmsbuild cmsbuild merged commit 228e405 into cms-sw:IB/CMSSW_11_0_X/master Nov 4, 2019
@gartung gartung deleted the bloom-filter branch May 4, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smuzaffar smuzaffar smuzaffar left review comments

Assignees
No one assigned
Labels
comparison-available externals-approved fully-signed orp-approved requires-external tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gartung @cmsbuild @smuzaffar @fabiocos