Update root on cmsdist master

[mrodozov]

please test
new commits on root 6.14 to be picked

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3284/console Started: 2019/10/31 12:49

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 3ee507b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c317f/3284/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c317f/3284/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939026
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2938684
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[smuzaffar]

+externals
@fabiocos , any objections updating root 6.14 for master IB. We want to back port it to 10.6.X ( #5313 )

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@smuzaffar @slava77 as we want to move forward asap to 6.18, better to merge this now, so it can be checked in next pre-release before the switch

[fabiocos]

+1

[slava77]

I didn't realize we are still using 6.14 in the cmssw master.
Thanks for merging.
This means that I can also check the update in the 110X. This is probably a nicer way than jumping directly to 106X

[smuzaffar]

@slava77 , latest root 6.14 is now available in CMSSW_11_0_X_2019-10-31-2300 and above. Please check if the pyroot enum issue is fixed.

[slava77]

I confirm that this now behaves as expected. More details follow, if needed.

using test.py

import os, re, sys, time, ROOT, subprocess
from DataFormats.FWLite import Events, Handle

muonHandle, muonLabel = Handle("std::vector<pat::Muon>"),"slimmedMuons"

ROOT.gROOT.SetBatch(True)
events = Events("root://cms-xrd-global.cern.ch//store/group/phys_muon/dmytro/tmp/store+mc+RunIIAutumn18MiniAOD+DYJetsToLL_M-50_TuneCP5_13TeV-madgraphMLM-pythia8+MINIAODSIM+102X_upgrade2018_realistic_v15-v1+80000+695EE995-7CA9-5A46-81EF-C6777A74C791.root")
nevents = 0

print "ROOT.reco.MatchedMuonFromGaugeOrHiggsBoson  = ", ROOT.reco.MatchedMuonFromGaugeOrHiggsBoson
print "ROOT.reco.GhostMuonFromGaugeOrHiggsBoson  = ", ROOT.reco.GhostMuonFromGaugeOrHiggsBoson
print "ROOT.reco.ExtendedMuonSimType.GhostMuonFromGaugeOrHiggsBoson  = ", ROOT.reco.ExtendedMuonSimType.GhostMuonFromGaugeOrHiggsBoson

for event in events:
    if nevents>=100: break
    nevents+=1
    event.getByLabel(muonLabel, muonHandle)
    muons = muonHandle.product()
    for muon in muons:
        if muon.simExtType()==ROOT.reco.GhostMuonFromGaugeOrHiggsBoson or muon.simExtType()>1e4 or muon.simExtType()<0:
            print "simExtType()==ROOT.reco.GhostMuonFromGaugeOrHiggsBoson or pos/neg: pt: %0.1f \tsimType: %d \textSimType: %d" % (muon.pt(),muon.simType(),muon.simExtType())
        if muon.simExtType()==ROOT.reco.GhostMuonFromGaugeOrHiggsBoson:
            print "simExtType()==ROOT.reco.GhostMuonFromGaugeOrHiggsBoson: pt: %0.1f \tsimType: %d \textSimType: %d" % (muon.pt(),muon.simType(),muon.simExtType())
        if muon.simExtType()==ROOT.reco.ExtendedMuonSimType.GhostMuonFromGaugeOrHiggsBoson:
            print "simExtType()==ROOT.reco.ExtendedMuonSimType.GhostMuonFromGaugeOrHiggsBoson: pt: %0.1f \tsimType: %d \textSimType: %d" % (muon.pt(),muon.simType(),muon.simExtType())

in CMSSW_11_0_X_2019-10-31-1100 there are several things wrong

ROOT.reco.MatchedMuonFromGaugeOrHiggsBoson  =  10
ROOT.reco.GhostMuonFromGaugeOrHiggsBoson  =  -10
ROOT.reco.ExtendedMuonSimType.GhostMuonFromGaugeOrHiggsBoson  =
Traceback (most recent call last):
  File "test.py", line 14, in <module>
    print "ROOT.reco.ExtendedMuonSimType.GhostMuonFromGaugeOrHiggsBoson  = ", ROOT.reco.ExtendedMuonSimType.GhostMuonFromGaugeOrHiggsBoson
AttributeError: type object 'int' has no attribute 'GhostMuonFromGaugeOrHiggsBoson'
#and, further ignoring the nested enum call:
simExtType()==ROOT.reco.GhostMuonFromGaugeOrHiggsBoson or pos/neg: pt: 1.1      simType: 4294967292     extSimType: 4294967286
simExtType()==ROOT.reco.GhostMuonFromGaugeOrHiggsBoson or pos/neg: pt: 1.0      simType: 4294967294     extSimType: 4294967292

in CMSSW_11_0_X_2019-10-31-2300 the behavior is as expected

ROOT.reco.MatchedMuonFromGaugeOrHiggsBoson  =  10
ROOT.reco.GhostMuonFromGaugeOrHiggsBoson  =  -10
ROOT.reco.ExtendedMuonSimType.GhostMuonFromGaugeOrHiggsBoson  =  -10
simExtType()==ROOT.reco.GhostMuonFromGaugeOrHiggsBoson or pos/neg: pt: 1.1      simType: -4     extSimType: -10
simExtType()==ROOT.reco.GhostMuonFromGaugeOrHiggsBoson: pt: 1.1         simType: -4     extSimType: -10
simExtType()==ROOT.reco.ExtendedMuonSimType.GhostMuonFromGaugeOrHiggsBoson: pt: 1.1     simType: -4     extSimType: -10
simExtType()==ROOT.reco.GhostMuonFromGaugeOrHiggsBoson or pos/neg: pt: 1.0      simType: -2     extSimType: -4