Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport sherpa 2.2.8 to 71X #5373

Merged
merged 1 commit into from Nov 24, 2019

Conversation

SiewYan
Copy link
Contributor

@SiewYan SiewYan commented Nov 22, 2019

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @SiewYan (SiewYan) for branch IB/CMSSW_7_1_X/stable.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 22, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3600/console Started: 2019/11/22 19:40

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de338f/3600/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 682523
  • DQMHistoTests: Total failures: 2880
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 679269
  • DQMHistoTests: Total skipped: 374
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -10 KiB( 10 files compared)
  • Checked 44 log files, 4 edm output root files, 11 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Nov 23, 2019

+1

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_7_1_X/stable IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 40e5085 into cms-sw:IB/CMSSW_7_1_X/stable Nov 24, 2019
@fabiocos
Copy link
Contributor

@SiewYan @qliphy I understand that you do not need a parallel update of openloops, please confirm

@SiewYan
Copy link
Contributor Author

SiewYan commented Nov 24, 2019

@fabiocos , thanks for the merge! The ultimate goal is to have latest openloops 2.1.0 alongside with sherpa 2.2.8.
The delay of backport was caused by obsolete git version (1.8.3.1) in 71X, which unable openloops 2.1.0 to function properly.
Due to the urgency, we decided to stick with openloops 2.0.0 for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants