Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vincia] remove VinciaMG4 and VinciaMG5 libs #5380

Merged
merged 1 commit into from Nov 26, 2019

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3634/console Started: 2019/11/26 06:47
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3635/console Started: 2019/11/26 07:59
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3636/console Started: 2019/11/26 08:00

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Tested at: efba3aa

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-731fc3/3634/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

>> Building shared library tmp/slc7_amd64_gcc820/src/GeneratorInterface/Pythia8Interface/src/GeneratorInterfacePythia8Interface/libGeneratorInterfacePythia8Interface.so
Copying tmp/slc7_amd64_gcc820/src/GeneratorInterface/Pythia8Interface/src/GeneratorInterfacePythia8Interface/libGeneratorInterfacePythia8Interface.so to productstore area:
Leaving library rule at GeneratorInterface/Pythia8Interface
Entering library rule at src/GeneratorInterface/Pythia8Interface/plugins
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-11-25-1100/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc 
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-11-25-1100/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:14:10: fatal error: Vincia/Vincia.h: No such file or directory
 #include "Vincia/Vincia.h"
          ^~~~~~~~~~~~~~~~~
compilation terminated.
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-11-25-1100/src/GeneratorInterface/Pythia8Interface/plugins/Py8toJetInput.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-11-25-1100/src/GeneratorInterface/Pythia8Interface/plugins/PowhegResHook.cc 


@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@fabiocos
Copy link
Contributor

@smuzaffar this requires cms-sw/cmssw#28301

@fabiocos
Copy link
Contributor

please test with cms-sw/cmssw#28301

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#28301

@smuzaffar
Copy link
Contributor Author

@fabiocos
Copy link
Contributor

@smuzaffar ok good, should I just abort this one?

@smuzaffar
Copy link
Contributor Author

No

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar
Copy link
Contributor Author

+externals
@fabiocos , the comparison results will not be ready by 11h. We can either delay the 11h IB by an hour or would you like to merge this PR before 11h?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@smuzaffar please delay the IB, I do not expect surprises but...

@fabiocos
Copy link
Contributor

+1

To avoid delaying too much next build

@cmsbuild cmsbuild merged commit fa1839d into IB/CMSSW_11_0_X/master Nov 26, 2019
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74b8e2/3636/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 37912 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2787584
  • DQMHistoTests: Total failures: 212265
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 2574975
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.128 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.063 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.543 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.352 KiB SiStrip/MechanicalView
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants