New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vincia] remove VinciaMG4 and VinciaMG5 libs #5380
Conversation
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_0_X/master. @cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks. |
-1 Tested at: efba3aa You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: >> Building shared library tmp/slc7_amd64_gcc820/src/GeneratorInterface/Pythia8Interface/src/GeneratorInterfacePythia8Interface/libGeneratorInterfacePythia8Interface.so Copying tmp/slc7_amd64_gcc820/src/GeneratorInterface/Pythia8Interface/src/GeneratorInterfacePythia8Interface/libGeneratorInterfacePythia8Interface.so to productstore area: Leaving library rule at GeneratorInterface/Pythia8Interface Entering library rule at src/GeneratorInterface/Pythia8Interface/plugins >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-11-25-1100/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-11-25-1100/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:14:10: fatal error: Vincia/Vincia.h: No such file or directory #include "Vincia/Vincia.h" ^~~~~~~~~~~~~~~~~ compilation terminated. >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-11-25-1100/src/GeneratorInterface/Pythia8Interface/plugins/Py8toJetInput.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-11-25-1100/src/GeneratorInterface/Pythia8Interface/plugins/PowhegResHook.cc |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
@smuzaffar this requires cms-sw/cmssw#28301 |
please test with cms-sw/cmssw#28301 |
The tests are being triggered in jenkins. |
tests ( https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3636/console ) is already running with cms-sw/cmssw#28301 |
@smuzaffar ok good, should I just abort this one? |
No |
Comparison job queued. |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@smuzaffar please delay the IB, I do not expect surprises but... |
+1 To avoid delaying too much next build |
Comparison is ready Comparison Summary:
|
No description provided.