Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenLoop-2.1.0] patch up missing lib for 11_0_X #5436

Merged
merged 2 commits into from Dec 20, 2019

Conversation

SiewYan
Copy link
Contributor

@SiewYan SiewYan commented Dec 17, 2019

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @SiewYan (SiewYan) for branch IB/CMSSW_11_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@@ -24,8 +24,8 @@ EOF
export SCONSFLAGS="-j %{compiling_processes}"
./openloops update --processes generator=0
./openloops libinstall lhc.coll
./openloops libinstall ppatt,ppatt_ew,ppattj,pplltt,pplltt_ew,ppllttj,ppllttj_ew,pplntt,pplnttj,ppwtt,ppwtt_ew,ppwttj,ppwttj_ew,ppztt,ppztt_ew,ppzttj,pphtt,pphtt_ew,pphttj
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SiewYan is the line above still needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, the user defined collection should consist ALL lhc.coll. But in case of overlapping lib, the installation will update/skip the lib.

@fabiocos
Copy link
Contributor

please test workflow 534.0,536.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 18, 2019

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 1f76a27
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-812596/4044/summary.html
CMSSW: CMSSW_11_0_X_2019-12-17-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-812596/4044/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-812596/534.0_sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+HARVESTGEN
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-812596/536.0_sherpa_ttbar_2j_MENLOPS_13TeV_MASTER+sherpa_ttbar_2j_MENLOPS_13TeV_MASTER+HARVESTGEN

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793498
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor

+1

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit e6cb55f into cms-sw:IB/CMSSW_11_0_X/master Dec 20, 2019
@SiewYan SiewYan deleted the patch-4 branch August 24, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants