Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0.X] Use OpenBlas instead of GSL Blas implementation #5549

Merged
merged 4 commits into from Feb 17, 2020

Conversation

cmsbuild
Copy link
Contributor

backport of #5540

Resolves #5528

Drop unused specs

  • photospline
  • suitesparse

and to make sure that we do not use lapack blas implementation we propose to drop it in favor of openblas.

Move gslcblas library in to separate directory so that no one can link against it.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Feb 14, 2020

A new Pull Request was created by @cmsbuild for branch IB/CMSSW_11_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar smuzaffar changed the title [11.1.X] Use OpenBlas instead of GSL Blas implementation [11.0.X] Use OpenBlas instead of GSL Blas implementation Feb 14, 2020
@mrodozov
Copy link
Contributor

please test

1 similar comment
@mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Feb 14, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4667/console Started: 2020/02/14 12:24

@cmsbuild
Copy link
Contributor Author

+1
Tested at: 4f27c6f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4033f/4667/summary.html
CMSSW: CMSSW_11_0_X_2020-02-13-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4033f/4667/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793498
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4d47264 into IB/CMSSW_11_0_X/master Feb 17, 2020
@smuzaffar smuzaffar deleted the backport-IB_CMSSW_11_0_X_master-5540 branch February 18, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants