[10.2.X] Use OpenBlas instead of GSL Blas implementation #5550

mrodozov · 2020-02-14T09:58:17Z

please test
backport of #5540

Change also the C++ standard flag

cmsbuild · 2020-02-14T10:18:39Z

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_2_X/gcc700.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

Backported from [11.1.X] Use OpenBlas instead of GSL Blas implementation #5540

cmsbuild · 2020-02-14T10:29:13Z

Pull request #5550 was updated.

mrodozov · 2020-02-14T10:34:20Z

please test

cmsbuild · 2020-02-14T10:34:42Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4665/console Started: 2020/02/14 11:37

cmsbuild · 2020-02-14T10:57:27Z

-1

Tested at: b07262d

Build:

I found compilation error when building:

+ export CXXFLAGS=-D__ROOFIT_NOBANNER
+ CXXFLAGS=-D__ROOFIT_NOBANNER
+ cmake ../root-6.12.07 -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/002e694a49a8bcdb4c214d16e073079a/opt/cmssw/slc6_amd64_gcc700/lcg/root/6.12.07-891be1 -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_Fortran_COMPILER=gfortran -DCMAKE_LINKER=ld -DCMAKE_VERBOSE_MAKEFILE=TRUE -Droot7=ON -Dfail-on-missing=ON -Dgnuinstall=OFF -Droofit=ON -Dvdt=OFF -Dhdfs=OFF -Dqt=OFF -Dqtgsi=OFF -Dpgsql=OFF -Dsqlite=OFF -Dmysql=OFF -Doracle=OFF -Dldap=OFF -Dkrb5=OFF -Dftgl=OFF -Dfftw3=ON -Dtbb=ON -Dimt=ON -DFFTW_INCLUDE_DIR=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc700/external/fftw3/3.3.2-omkpbe2/include -DFFTW_LIBRARY=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc700/external/fftw3/3.3.2-omkpbe2/lib/libfftw3.so -Dminuit2=ON -Dmathmore=ON -Dexplicitlink=ON -Dtable=ON -Dbuiltin_tbb=OFF -Dbuiltin_pcre=OFF -Dbuiltin_freetype=OFF -Dbuiltin_zlib=OFF -Dbuiltin_lzma=OFF -Dbuiltin_gsl=OFF -DGSL_ROOT_DIR=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc700/external/gsl/2.2.1-891be1 -DGSL_CBLAS_LIBRARY=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc700/external/OpenBLAS/0.2.20-gnimlf/lib/libopenblas.so -DGSL_CBLAS_LIBRARY_DEBUG=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc700/external/OpenBLAS/0.2.20-gnimlf/lib/libopenblas.so ' '
CMake Error: The source directory "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc6_amd64_gcc700/lcg/root/6.12.07-891be1/build/ " does not exist.
Specify --help for usage, or press the help button on the CMake GUI.
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.CqvC4Z (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.CqvC4Z (%build)

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-891be1/4665/summary.html

smuzaffar · 2020-02-14T22:21:51Z

backport of #5540

cmsbuild · 2020-02-14T22:24:09Z

Pull request #5550 was updated.

smuzaffar · 2020-02-14T22:24:36Z

please test

cmsbuild · 2020-02-14T22:24:55Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4684/console Started: 2020/02/14 23:40

cmsbuild · 2020-02-14T23:01:10Z

-1

Tested at: 6eb2ea2

Build:

I found compilation error when building:

+ export CXXFLAGS=-D__ROOFIT_NOBANNER
+ CXXFLAGS=-D__ROOFIT_NOBANNER
+ cmake ../root-6.12.07 -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/74da545e91b674044f8a370cde945965/opt/cmssw/slc6_amd64_gcc700/lcg/root/6.12.07-891be1 -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_Fortran_COMPILER=gfortran -DCMAKE_LINKER=ld -DCMAKE_VERBOSE_MAKEFILE=TRUE -Droot7=ON -Dfail-on-missing=ON -Dgnuinstall=OFF -Droofit=ON -Dvdt=OFF -Dhdfs=OFF -Dqt=OFF -Dqtgsi=OFF -Dpgsql=OFF -Dsqlite=OFF -Dmysql=OFF -Doracle=OFF -Dldap=OFF -Dkrb5=OFF -Dftgl=OFF -Dfftw3=ON -Dtbb=ON -Dimt=ON -DFFTW_INCLUDE_DIR=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc700/external/fftw3/3.3.2-omkpbe2/include -DFFTW_LIBRARY=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc700/external/fftw3/3.3.2-omkpbe2/lib/libfftw3.so -Dminuit2=ON -Dmathmore=ON -Dexplicitlink=ON -Dtable=ON -Dbuiltin_tbb=OFF -Dbuiltin_pcre=OFF -Dbuiltin_freetype=OFF -Dbuiltin_zlib=OFF -Dbuiltin_lzma=OFF -Dbuiltin_gsl=OFF -Dcxx17=ON -DGSL_ROOT_DIR=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc700/external/gsl/2.2.1-891be1 -DGSL_CBLAS_LIBRARY=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc700/external/OpenBLAS/0.2.20-gnimlf/lib/libopenblas.so -DGSL_CBLAS_LIBRARY_DEBUG=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc700/external/OpenBLAS/0.2.20-gnimlf/lib/libopenblas.so ' '
CMake Error: The source directory "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc6_amd64_gcc700/lcg/root/6.12.07-891be1/build/ " does not exist.
Specify --help for usage, or press the help button on the CMake GUI.
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.po66wf (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.po66wf (%build)

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-891be1/4684/summary.html

cmsbuild · 2020-02-17T10:54:18Z

Pull request #5550 was updated.

cmsbuild · 2020-02-17T10:56:46Z

Pull request #5550 was updated.

mrodozov · 2020-02-17T11:04:22Z

please test
for root 6.12 it's still the -Dcxx17=ON flag, this is in the log:
-- c++11 or c++14 mode requested but superseded by request for c++17 mode
and when the other flag was used (the new one) root7 was switched off and standard set to C++11

cmsbuild · 2020-02-17T11:04:45Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4702/console Started: 2020/02/17 12:11

cmsbuild · 2020-02-17T15:53:07Z

-1

Tested at: c3a6c16

CMSSW: CMSSW_10_2_X_2020-02-16-2300
SCRAM_ARCH: slc6_amd64_gcc700
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-891be1/4702/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test EcalDAQ_O2O_test had ERRORS

cmsbuild · 2020-02-17T15:53:10Z

Comparison job queued.

cmsbuild · 2020-02-17T16:40:02Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-891be1/4702/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 3007491
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3007300
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 129 log files, 14 edm output root files, 31 DQM output files

smuzaffar · 2020-02-17T16:43:27Z

+externals
unit test failure has nothing to do with this PR, it is already failing in IB (due to a know boost version issue)

cmsbuild · 2020-02-17T16:43:48Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_2_X/gcc700 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-02-17T17:54:38Z

+1

silviodonato · 2020-02-18T08:20:12Z

merge

mrodozov added 2 commits February 14, 2020 10:55

[10.2.X] Backport cms-sw#5540 on 10_2_X_gcc700

332e27e

change flag

009675b

Change also the C++ standard flag

cmsbuild added comparison-pending externals-pending orp-pending pending-signatures tests-pending labels Feb 14, 2020

add gsl changes and remove file

b07262d

cmsbuild added tests-started and removed tests-pending labels Feb 14, 2020

cmsbuild added tests-rejected and removed tests-started labels Feb 14, 2020

smuzaffar changed the title ~~[10.2.X] Backport #5540 on 10_2_X_gcc700~~ [10.2.X] Use OpenBlas instead of GSL Blas implementation Feb 14, 2020

cmsbuild added the backport-ok label Feb 14, 2020

Update root.spec

6eb2ea2

cmsbuild added tests-pending and removed tests-rejected labels Feb 14, 2020

cmsbuild added tests-started and removed tests-pending labels Feb 14, 2020

cmsbuild removed the tests-started label Feb 14, 2020

cmsbuild added the tests-rejected label Feb 14, 2020

Fix formatting with vi

935a601

cmsbuild added tests-pending and removed tests-rejected labels Feb 17, 2020

Remove tabs

c3a6c16

cmsbuild added tests-started and removed tests-pending labels Feb 17, 2020

cmsbuild added tests-rejected and removed tests-started labels Feb 17, 2020

cmsbuild added comparison-available and removed comparison-pending labels Feb 17, 2020

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Feb 17, 2020

cmsbuild added orp-approved and removed orp-pending labels Feb 17, 2020

silviodonato mentioned this pull request Feb 17, 2020

[11.1.X] Use OpenBlas instead of GSL Blas implementation #5540

Merged

cmsbuild merged commit b12b7b2 into cms-sw:IB/CMSSW_10_2_X/gcc700 Feb 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10.2.X] Use OpenBlas instead of GSL Blas implementation #5550

[10.2.X] Use OpenBlas instead of GSL Blas implementation #5550

mrodozov commented Feb 14, 2020 •

edited by smuzaffar

cmsbuild commented Feb 14, 2020 •

edited

cmsbuild commented Feb 14, 2020

mrodozov commented Feb 14, 2020

cmsbuild commented Feb 14, 2020 •

edited

cmsbuild commented Feb 14, 2020

smuzaffar commented Feb 14, 2020

cmsbuild commented Feb 14, 2020

smuzaffar commented Feb 14, 2020

cmsbuild commented Feb 14, 2020 •

edited

cmsbuild commented Feb 14, 2020

cmsbuild commented Feb 17, 2020

cmsbuild commented Feb 17, 2020

mrodozov commented Feb 17, 2020

cmsbuild commented Feb 17, 2020 •

edited

cmsbuild commented Feb 17, 2020

cmsbuild commented Feb 17, 2020

cmsbuild commented Feb 17, 2020

smuzaffar commented Feb 17, 2020 •

edited

cmsbuild commented Feb 17, 2020

silviodonato commented Feb 17, 2020

silviodonato commented Feb 18, 2020

[10.2.X] Use OpenBlas instead of GSL Blas implementation #5550

[10.2.X] Use OpenBlas instead of GSL Blas implementation #5550

Conversation

mrodozov commented Feb 14, 2020 • edited by smuzaffar

cmsbuild commented Feb 14, 2020 • edited

cmsbuild commented Feb 14, 2020

mrodozov commented Feb 14, 2020

cmsbuild commented Feb 14, 2020 • edited

cmsbuild commented Feb 14, 2020

smuzaffar commented Feb 14, 2020

cmsbuild commented Feb 14, 2020

smuzaffar commented Feb 14, 2020

cmsbuild commented Feb 14, 2020 • edited

cmsbuild commented Feb 14, 2020

cmsbuild commented Feb 17, 2020

cmsbuild commented Feb 17, 2020

mrodozov commented Feb 17, 2020

cmsbuild commented Feb 17, 2020 • edited

cmsbuild commented Feb 17, 2020

cmsbuild commented Feb 17, 2020

cmsbuild commented Feb 17, 2020

smuzaffar commented Feb 17, 2020 • edited

cmsbuild commented Feb 17, 2020

silviodonato commented Feb 17, 2020

silviodonato commented Feb 18, 2020

mrodozov commented Feb 14, 2020 •

edited by smuzaffar

cmsbuild commented Feb 14, 2020 •

edited

cmsbuild commented Feb 14, 2020 •

edited

cmsbuild commented Feb 14, 2020 •

edited

cmsbuild commented Feb 17, 2020 •

edited

smuzaffar commented Feb 17, 2020 •

edited