Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DD4hep] Bump to new version #5604

Merged
merged 1 commit into from Feb 28, 2020
Merged

[DD4hep] Bump to new version #5604

merged 1 commit into from Feb 28, 2020

Conversation

mrodozov
Copy link
Contributor

please test
@andresailer

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4890/console Started: 2020/02/26 14:36

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

mrodozov commented Feb 26, 2020 •
edited

this last changes are fixing our ROOT master and ROOT 6-20 builds (I really hope so) !
well done then, I don't have to deal with this myself

@cmsbuild
Copy link
Contributor

-1

Tested at: cc103e6

CMSSW: CMSSW_11_1_X_2020-02-25-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6795ac/4890/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

>> Entering Package PhysicsTools/TensorFlow
Entering library rule at PhysicsTools/TensorFlow
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-25-2300/src/PhysicsTools/TensorFlow/src/TBBSession.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-25-2300/src/PhysicsTools/TensorFlow/src/TensorFlow.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-25-2300/src/PhysicsTools/TensorFlow/src/NTSession.cc 
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-25-2300/src/PhysicsTools/TensorFlow/src/TBBSession.cc:51:10: fatal error: tensorflow/core/framework/graph.pb_text.h: No such file or directory
 #include "tensorflow/core/framework/graph.pb_text.h"
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-25-2300/src/PhysicsTools/TensorFlow/src/NTSession.cc:49:10: fatal error: tensorflow/core/framework/graph.pb_text.h: No such file or directory
 #include "tensorflow/core/framework/graph.pb_text.h"

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@mrodozov
Copy link
Contributor Author

please test for CMSSW_11_1_X_2020-02-26-1100

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4904/console Started: 2020/02/26 21:20

@cmsbuild
Copy link
Contributor

-1

Tested at: cc103e6

CMSSW: CMSSW_11_1_X_2020-02-26-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6795ac/4904/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-26-1100/src/DetectorDescription/DDCMS/src/Filter.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-26-1100/src/DetectorDescription/DDCMS/src/DDFilteredView.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-26-1100/src/DetectorDescription/DDCMS/src/DDSpecparRegistry.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-26-1100/src/DetectorDescription/DDCMS/src/DDShapes.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-26-1100/src/DetectorDescription/DDCMS/src/DDAlgoArguments.cc 
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-26-1100/src/DetectorDescription/DDCMS/src/DDAlgoArguments.cc:4:10: fatal error: DD4hep/BasicGrammar.h: No such file or directory
 #include "DD4hep/BasicGrammar.h"
          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-26-1100/src/DetectorDescription/DDCMS/src/DDAlgoArguments.cc:4:10: fatal error: DD4hep/BasicGrammar.h: No such file or directory
 #include "DD4hep/BasicGrammar.h"

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@mrodozov
Copy link
Contributor Author

@andresailer I'd assume
#include "DD4hep/BasicGrammar.h"
doesn't exist anymore ?

@mrodozov
Copy link
Contributor Author

Yup it's called Grammar.h now. I'll fix i in the morning

@mrodozov mrodozov mentioned this pull request Feb 27, 2020
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 27, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29055
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4921/console Started: 2020/02/27 17:52

@cmsbuild
Copy link
Contributor

+1
Tested at: cc103e6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a98959/4921/summary.html
CMSSW: CMSSW_11_1_X_2020-02-27-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a98959/4921/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2679706
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2679386
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@mrodozov
Copy link
Contributor Author

+externals
@silviodonato we need cms-sw/cmssw#29055 to go in with this

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@ianna
Copy link

ianna commented Feb 28, 2020

+1

@mrodozov
Copy link
Contributor Author

@ianna the cmssw one :)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5951d6b into IB/CMSSW_11_1_X/master Feb 28, 2020
@smuzaffar smuzaffar deleted the bump-to-next-dd4 branch March 6, 2020 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available externals-approved fully-signed orp-approved requires-external tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mrodozov @cmsbuild @ianna @silviodonato