Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LLVM flags #5631

Merged
merged 1 commit into from Mar 12, 2020
Merged

Update LLVM flags #5631

merged 1 commit into from Mar 12, 2020

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Mar 9, 2020

please test
following #5627

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5068/console Started: 2020/03/09 11:10

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2020

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2020

+1
Tested at: 48eb0f3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d708a2/5068/summary.html
CMSSW: CMSSW_11_1_X_2020-03-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2020

Comparison job queued.

@smuzaffar
Copy link
Contributor

Please test for CMSSW_11_1_CLANG_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d708a2/5068/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680577
  • DQMHistoTests: Total failures: 39
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2680219
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2020

-1

Tested at: 48eb0f3

CMSSW: CMSSW_11_1_CLANG_X_2020-03-08-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d708a2/5076/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testSerializationCommon had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d708a2/5076/summary.html

Comparison Summary:

  • You potentially added 5066 lines to the logs
  • Reco comparison results: 12852 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680577
  • DQMHistoTests: Total failures: 112784
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 2567468
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.019 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 136.793 ): -0.023 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 4.53 ): 0.004 KiB JetMET/SUSYDQM
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d708a2/5087/summary.html

Comparison Summary:

  • You potentially added 4452 lines to the logs
  • Reco comparison results: 12852 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680577
  • DQMHistoTests: Total failures: 112784
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 2567468
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.019 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 136.793 ): -0.023 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 4.53 ): 0.004 KiB JetMET/SUSYDQM
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

@mrodozov , can you please try to build locally and see why LLVM distribution size if now 1.3GB (instead of 500MB) https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d708a2/5076/external-tools.html

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 11, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5145/console Started: 2020/03/11 21:54

@cmsbuild
Copy link
Contributor

+1
Tested at: 48eb0f3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d708a2/5145/summary.html
CMSSW: CMSSW_11_1_X_2020-03-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d708a2/5145/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680593
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2680273
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the update-llvm-flags branch March 20, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants