Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more python tool updates #5639

Merged
merged 1 commit into from Mar 13, 2020

Conversation

davidlange6
Copy link
Contributor

(I still have local problems with pip dependencies that are unrelated to things I've changed.. so this may not work

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 13, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5166/console Started: 2020/03/13 09:11

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: 1452ed3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dfdf56/5166/summary.html
CMSSW: CMSSW_11_1_X_2020-03-12-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dfdf56/5166/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680593
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2680272
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

@davidlange6 , how can I reproduce the issue you get locally?

@davidlange6
Copy link
Contributor Author

davidlange6 commented Mar 13, 2020 via email

@smuzaffar
Copy link
Contributor

do you have PYTHONPATH set? Sometime it happens if our pip sees packages outside our build area.

@davidlange6
Copy link
Contributor Author

davidlange6 commented Mar 13, 2020 via email

@smuzaffar smuzaffar merged commit 6b8aec2 into cms-sw:IB/CMSSW_11_1_X/master Mar 13, 2020
@smuzaffar
Copy link
Contributor

something wronmg with hyperopt as it installed docs version 0.2.3 instead of hyperopt==0.2.3

/build/muz/p3/w/tmp/BUILDROOT/f7c939747d57a31eced47fbccaa5716d/opt/cmssw/slc7_amd64_gcc820/external/py2-hyperopt/0.2.3-cms/lib/python2.7/site-packages/hyperopt/base.py to base.pyc
    byte-compiling /build/muz/p3/w/tmp/BUILDROOT/f7c939747d57a31eced47fbccaa5716d/opt/cmssw/slc7_amd64_gcc820/external/py2-hyperopt/0.2.3-cms/lib/python2.7/site-packages/hyperopt/algobase.py to algobase.pyc
    running install_egg_info
    Copying docs.egg-info to /build/muz/p3/w/tmp/BUILDROOT/f7c939747d57a31eced47fbccaa5716d/opt/cmssw/slc7_amd64_gcc820/external/py2-hyperopt/0.2.3-cms/lib/python2.7/site-packages/docs-0.2.3-py2.7.egg-info
    running install_scripts
    Installing hyperopt-mongo-worker script to /build/muz/p3/w/tmp/BUILDROOT/f7c939747d57a31eced47fbccaa5716d/opt/cmssw/slc7_amd64_gcc820/external/py2-hyperopt/0.2.3-cms/bin
    writing list of installed files to '/build/muz/p3/w/BUILD/slc7_amd64_gcc820/external/py2-hyperopt/0.2.3-cms/cmsdist-tmp/pip-jG30hW-record/install-record.txt'
    Running setup.py install for docs: finished with status 'done'
  Removing source in /build/muz/p3/w/BUILD/slc7_amd64_gcc820/external/py2-hyperopt/0.2.3-cms/cmsdist-tmp/pip-ZfzMFF-build
Successfully installed docs-0.2.3

@davidlange6
Copy link
Contributor Author

thanks @smuzaffar - any idea why this seems not to affect the bot?

@smuzaffar
Copy link
Contributor

no idea :-(

@davidlange6
Copy link
Contributor Author

davidlange6 commented Mar 15, 2020 via email

@smuzaffar
Copy link
Contributor

smuzaffar commented Mar 15, 2020

what is py2-qtpy?

@davidlange6
Copy link
Contributor Author

davidlange6 commented Mar 15, 2020 via email

@smuzaffar
Copy link
Contributor

We have py2-qtconsole or pyqt. I do not see any issue with any of these . if you are talking about pyqt then it does not use build-with-pip and only depend on python, sip and qt so fix should not break it.

@davidlange6
Copy link
Contributor Author

davidlange6 commented Mar 15, 2020 via email

@smuzaffar
Copy link
Contributor

smuzaffar commented Mar 15, 2020

thisis telling the qtconsole now depends on qtpy (which is not in our distribution). As we are going to drop qt , I would suggest that we install jupyterlab instead of jupyter (which requires qtconsole).

@davidlange6
Copy link
Contributor Author

ha - so its real this time..
ok -for the moment, I'll just not update qtconsole as a first step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants