Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Eigne include directory in ROOT_INCLUDE_PATH #5734

Merged
merged 1 commit into from Apr 9, 2020

Conversation

smuzaffar
Copy link
Contributor

As reported here cms-sw/cmssw#29444 , now we have eigen dependency in dataformats and phase2 workflows workflows are failing as root is not able to find eigen headers. This PR propose to add eigen include directory in ROOT_INCLUDE_PATH which is used by root for finding headers at runtime.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5636/console Started: 2020/04/09 21:46

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2020

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

+externals
I am merging it so that it can go in next IB. This should fix the relvals issues we have seen in last IB.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2020

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2020

+1
Tested at: 1d4a019
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a78578/5636/summary.html
CMSSW: CMSSW_11_1_X_2020-04-09-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a78578/5636/summary.html

There are some workflows for which there are errors in the baseline:
20034.0 step 3
20434.0 step 3
23234.0 step 3
21234.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 30
  • DQMHistoTests: Total histograms compared: 2348370
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2348093
  • DQMHistoTests: Total skipped: 275
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
  • Checked 143 log files, 16 edm output root files, 30 DQM output files

@smuzaffar smuzaffar deleted the smuzaffar-patch-2 branch April 30, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants