New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated BuildRules tag to fix cuda compilation #5759
Conversation
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_1_X/master. @cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks. |
test parameters
|
please test for CMSSW_11_1_CLANG_X |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
please test for CMSSW_11_1_CLANG_X |
The tests are being triggered in jenkins.
|
-1 Tested at: 5213e02 CMSSW: CMSSW_11_1_CLANG_X_2020-04-17-2300 I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testSerializationCommon had ERRORS |
Comparison job queued. |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
Comparison is ready Comparison Summary:
|
New tag makes sure that we always use gcc flags for CUDA. With old build rules cuda was using CXXFLAGS of default compiler. So it was working for gcc based IBs but for CLANG based IBs it uses llvm CXXFLAGS (as llvm is default compiler in CLANG IBs). cms-sw/cmssw-config@1c35b87 makes sure that we always use gcc for cuda.