Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated BuildRules tag to fix cuda compilation #5759

Merged
merged 1 commit into from Apr 18, 2020

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Apr 18, 2020

New tag makes sure that we always use gcc flags for CUDA. With old build rules cuda was using CXXFLAGS of default compiler. So it was working for gcc based IBs but for CLANG based IBs it uses llvm CXXFLAGS (as llvm is default compiler in CLANG IBs). cms-sw/cmssw-config@1c35b87 makes sure that we always use gcc for cuda.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Apr 18, 2020

test parameters

  • full_cmssw = true

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_11_1_CLANG_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 18, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 5213e02
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb1ef9/5765/summary.html
CMSSW: CMSSW_11_1_CLANG_X_2020-04-17-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_11_1_CLANG_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 18, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

-1

Tested at: 5213e02

CMSSW: CMSSW_11_1_CLANG_X_2020-04-17-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb1ef9/5768/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testSerializationCommon had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit c5b9eda into IB/CMSSW_11_1_X/master Apr 18, 2020
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb1ef9/5768/summary.html

Comparison Summary:

  • You potentially added 4419 lines to the logs
  • Reco comparison results: 13855 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696435
  • DQMHistoTests: Total failures: 110571
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 2585539
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.019 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 136.793 ): -0.023 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 4.53 ): 0.004 KiB JetMET/SUSYDQM
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar smuzaffar deleted the smuzaffar-patch-5 branch April 30, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants