[GCC10] Fix scipy and sckikit-learn for gcc10

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6498/console Started: 2020/05/22 05:44

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[cmsbuild]

+1
Tested at: cdd3dce
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3bc128/6498/summary.html
CMSSW: CMSSW_11_1_X_2020-05-21-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3bc128/6498/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2694466
• DQMHistoTests: Total failures: 25
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2694392
• DQMHistoTests: Total skipped: 49
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 150 log files, 16 edm output root files, 35 DQM output files

[mrodozov]

the py2 version is unchanged, it only adds a fortran flag to deal with the new defaults in gcc10.
the change for py3 comes from here:
scipy/scipy#11842
which is above 1.4.1 and not an official release. The question is - is that ok ?
I tried to backport the same change for py2 but 1.2.3 is so much different/older than 1.4.x that this backport became too much of an effort and had to leave it.
Many python packages are having either no support for py2 since given version or some support that comes from old releases, like this one, which becomes a serious problem when one have to deal with the fortran part.

[davidlange6]

Ah - I think we didn’t consider the gcc support aspect of the end of python2 support issue.. Interesting.. Does the same flag solve the errors on scipy 1.4.1 as with 1.2.3? Perhaps we should live with that change rather than picking up an unreleased version of scipy? I don’t have a strong opinion, is just a thought. On May 22, 2020, at 11:51 AM, Mircho Rodozov <notifications@github.com<mailto:notifications@github.com>> wrote: the py2 version is unchanged, it only adds a fortran flag to deal with the new defaults in gcc10. the change for py3 comes from here: scipy/scipy#11842<scipy/scipy#11842> which is above 1.4.1 and not an official release. The question is - is that ok ? I tried to backport the same change for py2 but 1.2.3 is so much different/older than 1.4.x that this backport became too much of an effort and had to leave it. Many python packages are having either no support for py2 since given version or some support that comes from old releases, like this one, which becomes a serious problem when one have to deal with the fortran part. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub<#5842 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ3N3LE23JWOOHY6P6DRSZDK3ANCNFSM4NHLEATQ>.

[mrodozov]

I didn't think of this because the py3 solution is surgical and the py2 one is not: adds a flag globally to everything, but now it doesn't sound so bad ...
Then remove it with the next release for py3, seems the child solution ate its parent

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6510/console Started: 2020/05/22 13:33

[cmsbuild]

Pull request #5842 was updated.

[cmsbuild]

+1
Tested at: 267e2c6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3bc128/6510/summary.html
CMSSW: CMSSW_11_1_X_2020-05-21-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3bc128/6510/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2694466
• DQMHistoTests: Total failures: 49
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2694368
• DQMHistoTests: Total skipped: 49
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 150 log files, 16 edm output root files, 35 DQM output files

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)