Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCC10] fix mxnet and update to 1.6.0 tag #5899

Merged
merged 1 commit into from Jun 3, 2020

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Jun 2, 2020

please test
super weird bug, it was always there but gcc10 made it fail
got lucky that the author was also using gcc10 I guess

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6749/console Started: 2020/06/02 20:58

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

+1
Tested at: 1af320b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d3744/6749/summary.html
CMSSW: CMSSW_11_2_X_2020-06-02-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d3744/6749/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2783666
  • DQMHistoTests: Total failures: 51
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2783565
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@smuzaffar
Copy link
Contributor

@hqucms any objections on moving to mxnet 1.6?
@slava77 , the comparison difference are in L1 and message logger. Can you please give it a look?

@slava77
Copy link
Contributor

slava77 commented Jun 3, 2020

@slava77 , the comparison difference are in L1 and message logger. Can you please give it a look?

these are apparently false-positives.
I do not see anything changing related to mxnet. We run it with particleNet tagger in the standard workflows, which means that the update at least did not change the behavior for the existing model.

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit f6e44c1 into cms-sw:IB/CMSSW_11_2_X/master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants