Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build boost with python3 for PY3 IBs #5903

Merged
merged 1 commit into from Jun 16, 2020
Merged

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_2_X/py3.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#30099
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6782/console Started: 2020/06/03 20:10
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6784/console Started: 2020/06/03 23:16

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

-1

Tested at: dffb7d7

CMSSW: CMSSW_11_2_PY3_X_2020-06-02-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • #30039 @davidlange6: add packages used by headers in CondFormats
  • #29946 @dinardo: Minor changes in beampixel_dqm_sourceclient-live_cfg.py
  • #30084 @makortel: Move Alignment DQM modules back to Sequences
  • #30067 @camolezi: reduced boost use in PhysicsTools/Utilities

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adf787/6784/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adf787/6784/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adf787/6784/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test EcalDCS_O2O_test had ERRORS
---> test testSiStripPayloadInspector had ERRORS
---> test testPixelPayloadInspector had ERRORS
---> test TestFWCoreParameterSetDriver had ERRORS
---> test test-rivet-list had ERRORS
---> test testXGBoost_and_sklearn had ERRORS
---> test runtestRecoTauTagRecoTau had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • #30039 @davidlange6: add packages used by headers in CondFormats
  • #29946 @dinardo: Minor changes in beampixel_dqm_sourceclient-live_cfg.py
  • #30084 @makortel: Move Alignment DQM modules back to Sequences
  • #30067 @camolezi: reduced boost use in PhysicsTools/Utilities

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adf787/6784/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adf787/6784/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adf787/6784/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4232 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2785246
  • DQMHistoTests: Total failures: 958
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2784287
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.23600000000000004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 0.047 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): 0.047 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 136.731,... ): 0.008 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 136.731,... ): 0.008 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 140.53 ): 0.039 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 140.53 ): 0.039 KiB MessageLogger/Warnings
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#30194,cms-sw/cmssw#30099
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6959/console Started: 2020/06/11 16:06
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6963/console Started: 2020/06/11 16:55

@cmsbuild
Copy link
Contributor

-1

Tested at: dffb7d7

CMSSW: CMSSW_11_2_PY3_X_2020-06-10-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-222956/6963/summary.html

I found follow errors while testing this PR

Failed tests: Build HeaderConsistency

  • Build:

I found compilation error when building:

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/pythia8/302/include/Pythia8/Weights.h:140:7: warning: base class 'class Pythia8::WeightsBase' has accessible non-virtual destructor [-Wnon-virtual-dtor]
 class WeightsLHEF : public WeightsBase {
       ^~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/pythia8/302/include/Pythia8/Weights.h:140:7: warning: 'class Pythia8::WeightsLHEF' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_PY3_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/src/BiasedTauDecayer.cc:2:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_PY3_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/interface/BiasedTauDecayer.h:15:20: error: 'Pythia8::Couplings' has not been declared
                    Pythia8::Couplings* couplingsPtr);
                    ^~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_PY3_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/src/BiasedTauDecayer.cc:12:89: error: 'Couplings' has not been declared
     Info* infoPtr, Settings* settingsPtr, ParticleData* particleDataPtr, Rndm* rndmPtr, Couplings* couplingsPtr) {
                                                                                         ^~~~~~~~~


@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#30194,cms-sw/cmssw#30099
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6979/console Started: 2020/06/11 22:54

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b35bd8/6984/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4474 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2781013
  • DQMHistoTests: Total failures: 859
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780154
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@smuzaffar
Copy link
Contributor Author

+externals
this should be merged along with cms-sw/cmssw#30194

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/py3 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

please test with cms-sw/cmssw#30194

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 16, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#30194

@cmsbuild
Copy link
Contributor

-1

Tested at: dffb7d7

CMSSW: CMSSW_11_2_PY3_X_2020-06-15-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abc650/7102/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test TestFWCoreParameterSetDriver had ERRORS
---> test test-rivet-list had ERRORS
---> test materialBudgetTrackerPlots had ERRORS

@smuzaffar
Copy link
Contributor Author

@silviodonato , these are known failure for python3, so please ignore these errors for PY3 based Ibs,

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 18a1260 into IB/CMSSW_11_2_X/py3 Jun 16, 2020
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abc650/7102/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4495 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780391
  • DQMHistoTests: Total failures: 849
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2779542
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants