New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BuildRules] Support using -isystem instead of -I for system tools #5933
Conversation
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_2_X/master. @cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks. |
+1 |
Comparison job queued. |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
Comparison is ready Comparison Summary:
|
We get a lot of warnings coming from externals e.g. tbb, boost. New build rules allows to use
-isystemINCLUDE_DIR
instead of -IINCLUDE_DIR` which can instruct compiler to ignore warnings coming from headers under INCLUDE_DIR.An external tool can set following flag to declare its include as system includes.