Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.6] Include latest changes from 240 branch #5949

Merged
merged 1 commit into from Jun 17, 2020

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Jun 16, 2020

please test
the change was proposed and discussed here cms-externals/pythia8#22

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 16, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: a0b31d8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa2bd2/7095/summary.html
CMSSW: CMSSW_10_6_X_2020-06-15-2300
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa2bd2/7095/summary.html

Comparison Summary:

  • You potentially added 790 lines to the logs
  • Reco comparison results: 41175 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212264
  • DQMHistoTests: Total failures: 417079
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 2794848
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -24.974 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.786 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 10824.0,... ): -12.992 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 250202.181 ): 0.225 KiB SiStrip/MechanicalView
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

@silviodonato , please feel free to merge it. This is follow up of cms-externals/pythia8#22

@silviodonato
Copy link
Contributor

bug-fix
(see cms-externals/pythia8#22)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e9879d3 into IB/CMSSW_10_6_X/gcc700 Jun 17, 2020
@qliphy
Copy link
Contributor

qliphy commented Jun 20, 2020

@silviodonato @smuzaffar @mrodozov Thanks! Can you make a new 10_6_X release to include this?

@smuzaffar
Copy link
Contributor

@qliphy , there is a new request to patch pythia8 ( cms-externals/pythia8#23 ) . Shouldn't we wait for that to be included before building the 10.6 release?

@qliphy
Copy link
Contributor

qliphy commented Jun 20, 2020

@smuzaffar Ok, let's wait for that. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants