Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update RecoMET-METPUSubtraction data for backport DeepMET into CMSSW_10_6_X #6054

Merged

Conversation

yongbinfeng
Copy link

@yongbinfeng yongbinfeng commented Jul 9, 2020

The DeepMET was added to CMSSW from CMSSW_11_1_0_pre8,

cms-sw/cmssw#29764

with the modification to cms-data

cms-data/RecoMET-METPUSubtraction#5

and cms-dist

#5826

Now we would like to backport this change so DeepMET could be running with CMSSW_10_6_X: cms-sw/cmssw#30612

@steggema @intrepid42

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

A new Pull Request was created by @yongbinfeng (Yongbin Feng) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#30612

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

-1

Tested at: 5f5946a

  • Build:

I found compilation error when building:

++ . /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc700/external/python/2.7.14-pafccj/etc/profile.d/dependencies-setup.sh
+++ test X/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc700/external/gcc/7.0.0-pafccj '!=' X
+++ test X '!=' X
+++ . /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc700/external/zlib-x86_64/1.2.11-pafccj/etc/profile.d/init.sh
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc700/external/python/2.7.14-pafccj/etc/profile.d/dependencies-setup.sh: line 2: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc700/external/zlib-x86_64/1.2.11-pafccj/etc/profile.d/init.sh: No such file or directory
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.CiedMp (%prep)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.CiedMp (%prep)



You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea167c/7810/summary.html

@yongbinfeng
Copy link
Author

any expert could provide some help on this? we don't have much clue on how to fix this...

@mrodozov
Copy link
Contributor

mrodozov commented Jul 9, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

+1
Tested at: 5f5946a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-519eb8/7824/summary.html
CMSSW: CMSSW_10_6_X_2020-07-08-2300
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#30612

@cmsbuild
Copy link
Contributor

+1
Tested at: cae61c8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea167c/7838/summary.html
CMSSW: CMSSW_10_6_X_2020-07-09-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea167c/7838/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 76 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214618
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214282
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

Pull request #6054 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 14, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#30612

@cmsbuild
Copy link
Contributor

+1
Tested at: e337051
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea167c/7934/summary.html
CMSSW: CMSSW_10_6_X_2020-07-14-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea167c/7934/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 72 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214618
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214283
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

merge
adding new files, see cms-data/RecoMET-METPUSubtraction@V01-00-03...V01-01-00

@cmsbuild cmsbuild merged commit 2de789f into cms-sw:IB/CMSSW_10_6_X/gcc700 Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants