Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move back to ROOT 6.18 (11_1) #6068

Merged

Conversation

silviodonato
Copy link
Contributor

@silviodonato silviodonato commented Jul 13, 2020

Revert of #5942 and #5951.
Request from PPD to move back to ROOT 6.18 for the 11_1_0 reReco production in order to fix a PSS memory jump in DQM merge (@srimanob)

See: https://sft.its.cern.ch/jira/browse/ROOT-10927

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato (Silvio Donato) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 13, 2020

The tests are being triggered in jenkins.

@srimanob
Copy link

Issue at cms-sw/cmssw#30664

@mrodozov
Copy link
Contributor

use this commit 8f2bae3
and also what is the plan for this to build the release and turn it back to 6-20 ?

@srimanob
Copy link

@mrodozov
I think we should stay with 6.18 for 11_1 as it becomes production release now, and its lifetime is not that long. For 6.20, we is still on with with 11_2, but we definitely need fix from ROOT. The behaviour is on last 6.22 also.

@cmsbuild
Copy link
Contributor

Pull request #6068 was updated.

@silviodonato
Copy link
Contributor Author

@mrodozov

  • I moved the root tag to 2b91a0f8b8a094137a90fed9b340d99a3108c2d4 (taken from commit 8f2bae3)
  • The plan is to build a release as soon as possible because the memory issue is preventing us from running RelVals. I hoped to build of the release this night together with the night IB, but I want to see at least the result of the PR test before merging it. Likely I will start the build of 11_1_1 tomorrow morning after having merged this PR.
  • As @srimanob said, I think we can keep 6.18 in 11_1. About 11_2, we can keep ROOT 6.22 (ie. close Move back to ROOT 6.18 (11_2) #6069) or move back to 11_1 waiting for a bug-fix of ROOT (see https://sft.its.cern.ch/jira/browse/ROOT-10927). @srimanob do you need ROOT 6.18 to run RelVals in 11_2_0_pre2?

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 13, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: f93d3ad
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f04646/7915/summary.html
CMSSW: CMSSW_11_1_X_2020-07-13-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f04646/7915/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780740
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@cmsbuild
Copy link
Contributor

+1
Tested at: d0e407e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f04646/7922/summary.html
CMSSW: CMSSW_11_1_X_2020-07-13-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f04646/7922/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780741
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_11_1_X/master to IB/CMSSW_11_1_X/root618 July 14, 2020 13:18
@smuzaffar
Copy link
Contributor

+externals
@silviodonato , this PR is not based on IB/CMSSW_11_1_X/root618 branch. I am merging this and starting a 11.1.ROOT618_X IB.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/root618 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants