Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport highfive to 10_6_X #6105

Merged
merged 1 commit into from Jul 28, 2020

Conversation

SiewYan
Copy link
Contributor

@SiewYan SiewYan commented Jul 21, 2020

Backporting HighFive #5996 to 10_6_X. In reference to cms-sw/cmssw#30312 @smrenna

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @SiewYan (SiewYan) for branch IB/CMSSW_10_6_X/gcc820.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 21, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 674329b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b089fe/8174/summary.html
CMSSW: CMSSW_10_6_X_2020-07-20-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b089fe/8174/summary.html

Comparison Summary:

  • You potentially added 215 lines to the logs
  • Reco comparison results: 45911 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214618
  • DQMHistoTests: Total failures: 373313
  • DQMHistoTests: Total nulls: 9
  • DQMHistoTests: Total successes: 2840962
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1.816 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.786 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 136.85 ): 0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): 0.117 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -2.731 KiB SiStrip/MechanicalView
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@SiewYan SiewYan changed the title backport highfive to 10_6_X from 11_2_X backport highfive to 10_6_X Jul 23, 2020
@mrodozov mrodozov changed the base branch from IB/CMSSW_10_6_X/gcc820 to IB/CMSSW_10_6_X/gcc700 July 27, 2020 14:25
@mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 27, 2020

The tests are being triggered in jenkins.

@mrodozov
Copy link
Contributor

@SiewYan I'm assuming you want this backport for the "default" compiler for 10_6 branch which is gcc700
-> the differences in comparison

@cmsbuild
Copy link
Contributor

+1
Tested at: 674329b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b089fe/8308/summary.html
CMSSW: CMSSW_10_6_X_2020-07-27-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b089fe/8308/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214618
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214281
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@SiewYan
Copy link
Contributor Author

SiewYan commented Jul 28, 2020

@mrodozov , looks like the test on gcc700 is ok. And yes

@mrodozov
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cb89478 into cms-sw:IB/CMSSW_10_6_X/gcc700 Jul 28, 2020
@SiewYan SiewYan deleted the upmaster-highfive branch August 13, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants