Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROOT 6-22] Get latest commits #6114

Merged
merged 1 commit into from Jul 29, 2020
Merged

[ROOT 6-22] Get latest commits #6114

merged 1 commit into from Jul 29, 2020

Conversation

mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 27, 2020 •
edited

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_2_X/rootnext.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Tested at: 141339e

CMSSW: CMSSW_11_2_ROOT622_X_2020-07-26-0000
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b7e65/8332/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test TestFWCoreServicesDriver had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b7e65/8332/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2526188
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2526140
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 28, 2020 •
edited

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1

Tested at: 141339e

CMSSW: CMSSW_11_2_ROOT622_X_2020-07-27-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b7e65/8336/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

@@@@ Running edmWriteConfigs for BeamMonitor
--- Registered EDM Plugin: BeamMonitor
Entering library rule at src/DQM/BeamMonitor/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-07-27-2300/src/DQM/BeamMonitor/plugins/FakeBeamMonitor.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-07-27-2300/src/DQM/BeamMonitor/plugins/FakeBeamMonitor.cc: In member function 'virtual void FakeBeamMonitor::bookHistograms(dqm::legacy::DQMStore::IBooker&, const edm::Run&, const edm::EventSetup&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-07-27-2300/src/DQM/BeamMonitor/plugins/FakeBeamMonitor.cc:207:3: error: 'TDatime' was not declared in this scope
   TDatime da(eventTime);
   ^~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-07-27-2300/src/DQM/BeamMonitor/plugins/FakeBeamMonitor.cc:207:3: note: suggested alternative: 'adjtime'
   TDatime da(eventTime);
   ^~~~~~~

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

-1

Tested at: 141339e

CMSSW: CMSSW_11_2_ROOT622_X_2020-07-27-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b7e65/8355/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

@@@@ Running edmWriteConfigs for BeamMonitor
--- Registered EDM Plugin: BeamMonitor
Entering library rule at src/DQM/BeamMonitor/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-07-27-2300/src/DQM/BeamMonitor/plugins/FakeBeamMonitor.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-07-27-2300/src/DQM/BeamMonitor/plugins/FakeBeamMonitor.cc: In member function 'virtual void FakeBeamMonitor::bookHistograms(dqm::legacy::DQMStore::IBooker&, const edm::Run&, const edm::EventSetup&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-07-27-2300/src/DQM/BeamMonitor/plugins/FakeBeamMonitor.cc:207:3: error: 'TDatime' was not declared in this scope
   TDatime da(eventTime);
   ^~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-07-27-2300/src/DQM/BeamMonitor/plugins/FakeBeamMonitor.cc:207:3: note: suggested alternative: 'adjtime'
   TDatime da(eventTime);
   ^~~~~~~

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 29, 2020 •
edited

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 141339e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b7e65/8387/summary.html
CMSSW: CMSSW_11_2_ROOT622_X_2020-07-28-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b7e65/8387/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2525444
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2525385
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 03ddbea into cms-sw:IB/CMSSW_11_2_X/rootnext Jul 29, 2020
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/rootnext IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available externals-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrodozov @cmsbuild @smuzaffar