Update DD4Hep to latest on master #6148

mrodozov · 2020-08-05T09:18:48Z

please test
lets try and see if it integrates

please test

cmsbuild · 2020-08-05T09:19:08Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-08-04-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8576/console Started: 2020/08/05 15:12

cmsbuild · 2020-08-05T09:19:09Z

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

cmsbuild · 2020-08-05T16:14:11Z

+1
Tested at: 162462d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00d598/8576/summary.html
CMSSW: CMSSW_11_2_X_2020-08-04-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-08-05T16:14:13Z

Comparison job queued.

cmsbuild · 2020-08-05T16:46:35Z

Pull request #6148 was updated.

smuzaffar · 2020-08-05T16:47:10Z

test parameters

full_cmssw = true

smuzaffar · 2020-08-05T16:47:17Z

pelase test

cmsbuild · 2020-08-05T17:40:58Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00d598/8576/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2612401
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2612352
DQMHistoTests: Total skipped: 48
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

mrodozov · 2020-08-05T21:14:47Z

please test

cmsbuild · 2020-08-05T21:15:09Z

The tests are being triggered in jenkins.
Test Parameters:

BUILD_FULL_CMSSW = true
CMSSW_11_2_X_2020-08-04-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8598/console Started: 2020/08/05 23:16

cmsbuild · 2020-08-06T01:45:43Z

-1

Tested at: 2c52f08

CMSSW: CMSSW_11_2_X_2020-08-04-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00d598/8598/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test TestDQMOnlineClient-gem_dqm_sourceclient had ERRORS

cmsbuild · 2020-08-06T01:45:45Z

Comparison job queued.

cmsbuild · 2020-08-06T07:04:53Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00d598/8598/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2612401
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2612352
DQMHistoTests: Total skipped: 48
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

cmsbuild · 2020-08-08T16:51:32Z

-1

Tested at: 2c52f08

CMSSW: CMSSW_11_2_X_2020-08-07-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00d598/8670/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test TestPoolInput had ERRORS

cmsbuild · 2020-08-08T16:51:34Z

Comparison job queued.

cmsbuild · 2020-08-08T18:17:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00d598/8670/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2612401
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2612341
DQMHistoTests: Total skipped: 48
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
Checked 149 log files, 22 edm output root files, 35 DQM output files

mrodozov · 2020-08-10T12:27:44Z

@slava77 could you have a look into this 8 differences ?

cvuosalo · 2020-08-10T23:08:47Z

Testing with CMSSW_11_2_X_2020-08-07-2300, there is a core dump for testDD4hepFilteredView in DetectorDescription/DDCMS. I will investigate some more.

mrodozov · 2020-08-11T12:50:34Z

please test
lets see the test. it doesn't show in PR testing
I'll run it by hand, too

cmsbuild · 2020-08-11T12:50:57Z

The tests are being triggered in jenkins.
Test Parameters:

BUILD_FULL_CMSSW = true
CMSSW_11_2_X_2020-08-11-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8699/console Started: 2020/08/11 14:51

cmsbuild · 2020-08-11T17:17:40Z

+1
Tested at: 2c52f08
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00d598/8699/summary.html
CMSSW: CMSSW_11_2_X_2020-08-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-08-11T17:17:42Z

Comparison job queued.

cmsbuild · 2020-08-11T18:45:17Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00d598/8699/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2612401
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2612347
DQMHistoTests: Total skipped: 48
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
Checked 149 log files, 22 edm output root files, 35 DQM output files

cvuosalo · 2020-08-11T20:13:04Z

Why has this PR been merged? I see it causing crashes.

mrodozov · 2020-08-11T20:17:34Z

To have it in the next IB and see if it's crashing the tests.
If it is I'll just revert it to the prev state for the tomorrow 11:00 IB

cvuosalo · 2020-08-11T21:15:56Z

The test DetectorDescription/DDCMS/test/python/testGeometry2021FromDB.py reads the geometry (XMLFILE_Geometry_110YV2_Extended2021_mc) from the DB and then processes it with DD4hep. It looks like this old geometry has an error that v13x of DD4hep is now sensitive to. If so, then we would have a big problem with backward compatibility.

%MSG-i Root_Information:  DDCMSDetector:test TGeoManager::SetTopVolume()  11-Aug-2020 23:02:42 CEST Run: 1 Event: 1
Top volume is world_volume. Master volume is world_volume
%MSG
%MSG-i Root_Information:  DDCMSDetector:test TGeoNavigator::BuildCache()  11-Aug-2020 23:02:42 CEST Run: 1 Event: 1
--- Maximum geometry depth set to 100
%MSG
DD4CMS           ERROR Exception while processing xml source:xml-memory-buffer
DD4CMS           ERROR ----> Handle_t::attr_ptr: Element [rSolid] has no attribute of type ''
dd4hep: Error interpreting XML nodes of type <LogicalPart/>
dd4hep: Error interpreting XML nodes of type <LogicalPartSection/>

cvuosalo · 2020-08-12T19:56:28Z

Tests with the new CMSSW_11_2_X_2020-08-12-1100 IB that contains the new version of DD4hep are clean. There appears to be no problem with this new version. It continues to return lengths as centimeters, as our code expects.

The previous errors I reported must have been due to a misconfigured test setup. We need to figure out a reliable way to create a test setup for testing new versions of DD4hep outside of an IB.

Update DD4Hep to latest on master

162462d

please test

cmsbuild added comparison-pending externals-pending orp-pending pending-signatures tests-pending labels Aug 5, 2020

cmsbuild added tests-started and removed tests-pending labels Aug 5, 2020

cmsbuild added tests-approved and removed tests-started labels Aug 5, 2020

Update dd4hep.spec

2c52f08

cmsbuild added tests-pending and removed tests-approved labels Aug 5, 2020

cmsbuild added tests-started and removed tests-pending labels Aug 5, 2020

cmsbuild added tests-rejected and removed tests-started labels Aug 6, 2020

cmsbuild added tests-rejected and removed tests-started labels Aug 8, 2020

cmsbuild added comparison-available and removed comparison-pending labels Aug 8, 2020

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-rejected labels Aug 11, 2020

cmsbuild added tests-started and removed tests-pending labels Aug 11, 2020

cmsbuild added tests-approved and removed tests-started labels Aug 11, 2020

cmsbuild added comparison-available and removed comparison-pending labels Aug 11, 2020

mrodozov merged commit b886f23 into IB/CMSSW_11_2_X/master Aug 11, 2020

mrodozov deleted the mrodozov-patch-4 branch August 11, 2020 20:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update DD4Hep to latest on master #6148

Update DD4Hep to latest on master #6148

mrodozov commented Aug 5, 2020

cmsbuild commented Aug 5, 2020 •

edited

cmsbuild commented Aug 5, 2020

cmsbuild commented Aug 5, 2020

cmsbuild commented Aug 5, 2020

cmsbuild commented Aug 5, 2020

smuzaffar commented Aug 5, 2020

smuzaffar commented Aug 5, 2020

cmsbuild commented Aug 5, 2020

mrodozov commented Aug 5, 2020

cmsbuild commented Aug 5, 2020 •

edited

cmsbuild commented Aug 6, 2020

cmsbuild commented Aug 6, 2020

cmsbuild commented Aug 6, 2020

cmsbuild commented Aug 8, 2020

cmsbuild commented Aug 8, 2020

cmsbuild commented Aug 8, 2020

mrodozov commented Aug 10, 2020

cvuosalo commented Aug 10, 2020

mrodozov commented Aug 11, 2020 •

edited

cmsbuild commented Aug 11, 2020 •

edited

cmsbuild commented Aug 11, 2020

cmsbuild commented Aug 11, 2020

cmsbuild commented Aug 11, 2020

cvuosalo commented Aug 11, 2020

mrodozov commented Aug 11, 2020

cvuosalo commented Aug 11, 2020

cvuosalo commented Aug 12, 2020

Update DD4Hep to latest on master #6148

Update DD4Hep to latest on master #6148

Conversation

mrodozov commented Aug 5, 2020

cmsbuild commented Aug 5, 2020 • edited

cmsbuild commented Aug 5, 2020

cmsbuild commented Aug 5, 2020

cmsbuild commented Aug 5, 2020

cmsbuild commented Aug 5, 2020

smuzaffar commented Aug 5, 2020

smuzaffar commented Aug 5, 2020

cmsbuild commented Aug 5, 2020

mrodozov commented Aug 5, 2020

cmsbuild commented Aug 5, 2020 • edited

cmsbuild commented Aug 6, 2020

cmsbuild commented Aug 6, 2020

cmsbuild commented Aug 6, 2020

cmsbuild commented Aug 8, 2020

cmsbuild commented Aug 8, 2020

cmsbuild commented Aug 8, 2020

mrodozov commented Aug 10, 2020

cvuosalo commented Aug 10, 2020

mrodozov commented Aug 11, 2020 • edited

cmsbuild commented Aug 11, 2020 • edited

cmsbuild commented Aug 11, 2020

cmsbuild commented Aug 11, 2020

cmsbuild commented Aug 11, 2020

cvuosalo commented Aug 11, 2020

mrodozov commented Aug 11, 2020

cvuosalo commented Aug 11, 2020

cvuosalo commented Aug 12, 2020

cmsbuild commented Aug 5, 2020 •

edited

cmsbuild commented Aug 5, 2020 •

edited

mrodozov commented Aug 11, 2020 •

edited

cmsbuild commented Aug 11, 2020 •

edited