Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test latest crab client #6162

Merged
merged 2 commits into from Aug 12, 2020
Merged

Conversation

belforte
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @belforte (Stefano Belforte) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor

I'll see how did you proceeded with older version and merge it after that

@mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 11, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 8a45ac4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc0a29/8703/summary.html
CMSSW: CMSSW_11_2_X_2020-08-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc0a29/8703/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2612401
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2612347
  • DQMHistoTests: Total skipped: 48
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@mrodozov
Copy link
Contributor

@belforte it can be integrated. can it go in ?

@belforte
Copy link
Contributor Author

@mrodozov yes, certainly. Updating crab-dev is never a problem. I will try to make a new PR tomorrow for prod and pre to address the problem with py2-future

@cmsbuild
Copy link
Contributor

Pull request #6162 was updated.

@belforte
Copy link
Contributor Author

Please merge with this latest change as well. No need to re-test, but fell free. Thanks.

@cmsbuild
Copy link
Contributor

-1

Tested at: 3dabbcf

CMSSW: CMSSW_11_2_X_2020-08-11-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc0a29/8716/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Wed Aug 12 07:30:23 2020-date Wed Aug 12 07:16:00 2020 s - exit: 34304

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc0a29/8716/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2612401
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2612347
  • DQMHistoTests: Total skipped: 48
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@mrodozov
Copy link
Contributor

mrodozov commented Aug 12, 2020

@belforte I should close this, correct ? I've inspected the case with the missing py2-future in the 9 releases (I did it yesterday) . The thing is - even if I put it in the externals, it will be there for IBs but still missing from the 9_4 release.
Unless we build a release of course 😅

@smuzaffar
Copy link
Contributor

@mrodozov , this should be merged. This updates crab dev. There are 3 card spec and these prs were updating different crab spec file

@belforte
Copy link
Contributor Author

belforte commented Aug 12, 2020

@mrodozov please merge. this will only affect crab-dev (yeah.. I made 3 different PR's for crab-prod, crab-pre and crab-dev) and this will create a new up-to-date version where the py2-futurize problem is rolled back. A new release for CMSSW_9_ will not do, I suspect that py2-futurize is missing in other series as well. In any case that change was not sufficient for py3 compatibility of CRABClient, it will be something to address with much more care and time.

@mrodozov
Copy link
Contributor

ah this is a dev version. alright :)

@mrodozov
Copy link
Contributor

please test
lets try this add on one more time before 2300

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 12, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 3dabbcf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc0a29/8730/summary.html
CMSSW: CMSSW_11_2_X_2020-08-12-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@mrodozov mrodozov merged commit df09298 into cms-sw:IB/CMSSW_11_2_X/master Aug 12, 2020
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc0a29/8730/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2612401
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2612352
  • DQMHistoTests: Total skipped: 48
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants