Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11_2_X] enabling Sherpa2ShortHepMC in sherpa #6193

Merged
merged 1 commit into from Aug 25, 2020

Conversation

SiewYan
Copy link
Contributor

@SiewYan SiewYan commented Aug 24, 2020

Enable Sherpa2ShortHepMC function (MISSING) during Sherpa::FillHepMCEvent.

Integrates fix (Sherpa 2.2.8) from Emilien Chapon, Junquan Tao and Rajdeep. Fix was modified for sherpa 2.2.10 to include HepMC3 version of Sherpa2ShortHepMC:

HepMC2_Interface::Sherpa2ShortHepMC
HepMC3_Interface::Sherpa2ShortHepMC

NOTE, During FillHepMCEvent, different arguments are provided for Sherpa2ShortHepMC between class HepMC2_Interface and HepMC3_Interface:

p_hepmc2->Sherpa2ShortHepMC(blobs, event, blobs->Weight());
p_hepmc3->Sherpa2ShortHepMC(blobs, event);

@SiewYan
Copy link
Contributor Author

SiewYan commented Aug 24, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @SiewYan (SiewYan) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@SiewYan SiewYan changed the title enabling Sherpa2ShortHepMC in sherpa [11_2_X] enabling Sherpa2ShortHepMC in sherpa Aug 24, 2020
@cmsbuild
Copy link
Contributor

+1
Tested at: 7edd79c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-625b6f/8872/summary.html
CMSSW: CMSSW_11_2_X_2020-08-23-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-625b6f/8872/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609656
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2609633
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 25, 2020

+1

@cmsbuild cmsbuild merged commit 51c7962 into cms-sw:IB/CMSSW_11_2_X/master Aug 25, 2020
@SiewYan SiewYan deleted the 112X-sherpa-patch branch August 25, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants