Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Update to Rivet 3.1.2 and Yoda 1.8.3"" #6209

Merged
merged 1 commit into from Sep 7, 2020

Conversation

mseidel42
Copy link
Contributor

Reverts #6103

Multi-stream problems fixed in cms-sw/cmssw#30888

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2020

A new Pull Request was created by @intrepid42 (Markus Seidel) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2020

-1

Tested at: da5b6cd

CMSSW: CMSSW_11_2_X_2020-09-02-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c9530/9095/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-02-2300/src/RecoJets/JetProducers/plugins/CompoundJetProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-02-2300/src/RecoJets/JetProducers/plugins/ECFAdder.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-02-2300/src/RecoJets/JetProducers/plugins/FastjetJetProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-02-2300/src/RecoJets/JetProducers/plugins/FixedGridRhoProducer.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-02-2300/src/RecoJets/JetProducers/plugins/CSJetProducer.cc: In member function 'virtual void cms::CSJetProducer::runAlgorithm(edm::Event&, const edm::EventSetup&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-02-2300/src/RecoJets/JetProducers/plugins/CSJetProducer.cc:149:44: error: no matching function for call to 'fastjet::contrib::ConstituentSubtractor::set_do_mass_subtraction(bool)'
     subtractor.set_do_mass_subtraction(true);
                                            ^
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-02-2300/src/RecoJets/JetProducers/plugins/CSJetProducer.cc:11:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/fastjet-contrib/1.044-1c9530/include/fastjet/contrib/ConstituentSubtractor.hh:185:10: note: candidate: 'void fastjet::contrib::ConstituentSubtractor::set_do_mass_subtraction()'
     void set_do_mass_subtraction();


@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2020

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@mseidel42
Copy link
Contributor Author

Ah, we need to revert this one again: cms-sw/cmssw#30838

@mseidel42
Copy link
Contributor Author

Needs cms-sw/cmssw#31355

@mrodozov
Copy link
Contributor

mrodozov commented Sep 3, 2020

please test with cms-sw/cmssw#31355
right ?

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#31355

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2020

+1
Tested at: da5b6cd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d86e10/9107/summary.html
CMSSW: CMSSW_11_2_X_2020-09-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d86e10/9107/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2609644
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#31355
to get the new build rules

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#31355

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2020

+1
Tested at: da5b6cd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d86e10/9143/summary.html
CMSSW: CMSSW_11_2_X_2020-09-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d86e10/9143/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2609638
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Sep 7, 2020

+operations

@qliphy
Copy link
Contributor

qliphy commented Sep 7, 2020

+1

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2020

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants